Change in vdsm[master]: libvirtvm: set volume the format in live snapshots

Hello Federico Simoncelli,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/9129

to review the following change.

Change subject: libvirtvm: set volume the format in live snapshots
......................................................................

libvirtvm: set volume the format in live snapshots

When we update the drive objects (and configurations) at the end of
a live snapshot we should also update the format to be "cow" in order
to start requesting the drive extensions on block devices.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=874481
Change-Id: Ia5535cc8ad55441046e81aa329fac82a354592b9
Signed-off-by: Federico Simoncelli 
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/9129/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 86e39a3..ca31a43 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1853,6 +1853,7 @@
             newDrives[vmDevName] = tgetDrv.copy()
             newDrives[vmDevName]["poolID"] = vmDrive.poolID
             newDrives[vmDevName]["name"] = vmDevName
+            newDrives[vmDevName]["format"] = "cow"

try:
                 newDrives[vmDevName]["path"] = \

--
To view, visit http://gerrit.ovirt.org/9129
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5535cc8ad55441046e81aa329fac82a354592b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Federico Simoncelli

Ayal Baron has posted comments on this change.

Change subject: libvirtvm: set volume the format in live snapshots
......................................................................

Patch Set 1: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9129
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5535cc8ad55441046e81aa329fac82a354592b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Federico Simoncelli

Ayal Baron has submitted this change and it was merged.

Change subject: libvirtvm: set volume the format in live snapshots
......................................................................

libvirtvm: set volume the format in live snapshots

When we update the drive objects (and configurations) at the end of
a live snapshot we should also update the format to be "cow" in order
to start requesting the drive extensions on block devices.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=874481
Change-Id: Ia5535cc8ad55441046e81aa329fac82a354592b9
Signed-off-by: Federico Simoncelli 
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Ayal Baron: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9129
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5535cc8ad55441046e81aa329fac82a354592b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Federico Simoncelli