Change in vdsm[master]: remove unused fields in vm stats

Arik Hadas has uploaded a new change for review.

Change subject: remove unused fields in vm stats
......................................................................

remove unused fields in vm stats

The values of 'vmName' and 'vmType' are not read by the engine,
thus removed. The value of 'pid' is read (it is optional - the
engine first checks if it is reported) and doesn't do anything
with this value, thus it is removed as well.

Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/64973/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c38eaef..ad8f310 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1222,9 +1222,6 @@
         """
         stats = {
             'vmId': self.conf['vmId'],
-            'vmName': self.name,
-            'pid': self.conf['pid'],
-            'vmType': self.conf['vmType'],
             'kvmEnable': self._kvmEnable,
             'acpiEnable': self.conf.get('acpiEnable', 'true')}
         if 'cdrom' in self.conf:


-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: remove unused fields in vm stats
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Arik Hadas has posted comments on this change.

Change subject: remove unused fields in vm stats
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: remove unused fields in vm stats
......................................................................


Patch Set 1: Code-Review-1

not sure MOM uses this. -1 for visibility
Vdsm tries hard to be backward compatible, so let's check if a well known user
actually consumes this data.
Anyway, we should first deprecate this, then remove.

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Martin Sivak]

Martin Sivák has posted comments on this change.

Change subject: remove unused fields in vm stats
......................................................................


Patch Set 1: Code-Review-1

MOM uses vmName and pid.

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Arik Hadas has posted comments on this change.

Change subject: remove unused fields in vm stats
......................................................................


Patch Set 1: -Verified

indeed, I didn't take MOM into account.
Martin, I guess MOM needs vmName only for logging, right? and why does it need to get the
pid?

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Change in vdsm[master]: remove unused field in vm stats

gerrit-hooks has posted comments on this change.

Change subject: remove unused field in vm stats
......................................................................


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Change in vdsm[master]: remove unused field in vm stats

Arik Hadas has posted comments on this change.

Change subject: remove unused field in vm stats
......................................................................


Patch Set 2:

Francesco, I understand the aim to preserve backward compatibility - but I think we should
be realistic, I believe no-one other than components we develop is using vdsm and I never
see any statement where we declare our intention to preserve compatibility with external
tools that one may develop - such tools are supposed to interact with the engine I
believe. so I think vmType can be dropped..

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No