Change in vdsm[ovirt-3.5.0]: hosted-engine: don't log the whole backtrace for expected pr...

[Jiri Moskovcak]

Jiří Moskovčák has uploaded a new change for review.

Change subject: hosted-engine: don't log the whole backtrace for expected problems
......................................................................

hosted-engine: don't log the whole backtrace for expected problems

when deploying host for hosted engine, vdsm starts using the HE
broker api before the deployment is finished, and the required config
file is not writen, so it results in the exception which polutes the
log

Change-Id: Ib03fbe80dfd111ef9a2e4f2137433e358f6479bb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1045053
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/31432
Reviewed-by: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
(cherry picked from commit 3edc284263a291330be982b7fbabb6f4070dd61d)
---
M vdsm/API.py
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/34004/1

diff --git a/vdsm/API.py b/vdsm/API.py
index b2caf44..f69361a 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -27,6 +27,7 @@
 import copy
 import time
 import logging
+import errno
 
 from network.errors import ConfigNetworkError
 from network.errors import ERR_BAD_NIC
@@ -1683,6 +1684,17 @@
                     i['active'] = stats[host_id]['live-data']
                     i['score'] = stats[host_id]['score']
                     i['localMaintenance'] =
stats[host_id]['maintenance']
+            except IOError as ex:
+                if ex.errno == errno.ENOENT:
+                    self.log.error(
+                        ("failed to retrieve Hosted Engine HA score
'{0}'"
+                         "Is the Hosted Engine setup finished?")
+                        .format(str(ex))
+                    )
+                else:
+                    self.log.exception(
+                        "failed to retrieve Hosted Engine HA score"
+                    )
             except Exception:
                 self.log.exception("failed to retrieve Hosted Engine HA info")
         return i


-- 
To view, visit http://gerrit.ovirt.org/34004
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib03fbe80dfd111ef9a2e4f2137433e358f6479bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5.0
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: hosted-engine: don't log the whole backtrace for expected problems
......................................................................


Patch Set 1: Code-Review-1

Log noise removal should not be a reason to delay 3.5.0.

-- 
To view, visit http://gerrit.ovirt.org/34004
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib03fbe80dfd111ef9a2e4f2137433e358f6479bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5.0
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Jiri Moskovcak]

Jiří Moskovčák has posted comments on this change.

Change subject: hosted-engine: don't log the whole backtrace for expected problems
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/34004
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib03fbe80dfd111ef9a2e4f2137433e358f6479bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5.0
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Jiri Moskovcak]

Jiří Moskovčák has abandoned this change.

Change subject: hosted-engine: don't log the whole backtrace for expected problems
......................................................................


Abandoned

Abandoning per comment #3
Log noise removal should not be a reason to delay 3.5.0.

-- 
To view, visit http://gerrit.ovirt.org/34004
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib03fbe80dfd111ef9a2e4f2137433e358f6479bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5.0
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org