Change in vdsm[master]: Integrate deathSignal with execCmd

Saggi Mizrahi has uploaded a new change for review.

Change subject: Integrate deathSignal with execCmd
......................................................................

Integrate deathSignal with execCmd

Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Signed-off-by: Saggi Mizrahi 
---
M vdsm/storage/misc.py
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/6242/1
--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 6: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 6: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 9: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 7: Integrate deathSignal with execCmd
I live in a different timezone. Could you explain here if this solves a specific bug, or otherwise give the use case.

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mike Kolesnik 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

Saggi Mizrahi has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 9: (1 inline comment)

....................................................
Commit Message
Line 7: Integrate deathSignal with execCmd
Currently when VDSM dies we try and kill everything when we wake back up. This can help us by having the kernel kill child-processes when VDSM dies immediately.

I need it for the new images

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 10:

Build Failed

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/423/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Ayal Baron has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 10: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Patch Set 10: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice79d10ae6bfb0dbb61633fe8a3fce1e26943f14
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has abandoned this change.

Change subject: Integrate deathSignal with execCmd
......................................................................

Abandoned

done a long time later by http://gerrit.ovirt.org/18074