Change in vdsm[master]: remove redundant import misc

ShaoHe Feng has uploaded a new change for review.

Change subject: remove redundant import misc
......................................................................

remove redundant import misc

there is already "import storage.misc as misc"

Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Signed-off-by: ShaoHe Feng 
---
M vdsm/supervdsmServer.py
1 file changed, 3 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/9372/1

diff --git a/vdsm/supervdsmServer.py b/vdsm/supervdsmServer.py
index 34fefdb..840fef0 100755
--- a/vdsm/supervdsmServer.py
+++ b/vdsm/supervdsmServer.py
@@ -47,9 +47,8 @@
 from storage.fileUtils import chown, resolveGid, resolveUid
 from storage.fileUtils import validateAccess as _validateAccess
 from vdsm.constants import METADATA_GROUP, EXT_UDEVADM, \
-        DISKIMAGE_USER, DISKIMAGE_GROUP, P_LIBVIRT_VMCHANNELS
+    DISKIMAGE_USER, DISKIMAGE_GROUP, P_LIBVIRT_VMCHANNELS
 from storage.devicemapper import _removeMapping, _getPathsStatus
-import storage.misc
 import configNetwork
 from vdsm.config import config
 import tc
@@ -216,8 +215,8 @@
     @logDecorator
     def udevTrigger(self, guid):
         cmd = [EXT_UDEVADM, 'trigger', '--verbose', '--action', 'change',
-                '--property-match=DM_NAME=%s' % guid]
-        rc, out, err = storage.misc.execCmd(cmd, sudo=False)
+               '--property-match=DM_NAME=%s' % guid]
+        rc, out, err = misc.execCmd(cmd, sudo=False)
         if rc:
             raise OSError(errno.EINVAL, "Could not trigger change for device \
                           %s, out %s\nerr %s" % (guid, out, err))

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/78/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/112/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/78/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/112/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Hunt Xu has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: oVirt Jenkins CI Server

Mark Wu has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1: I would prefer that you didn't submit this

there's a usage of storage.misc in line 220, so ...

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu

ShaoHe Feng has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1:

220line, already change  storage.misc to misc

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim

Yaniv Bronhaim has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim

Mark Wu has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

Sorry,  I didn't notice your change.

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim

ShaoHe Feng has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 1: I would prefer that you didn't submit this

patch too old..., please rebase.

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/261/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/227/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/227/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/261/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

ShaoHe Feng has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 2:

rebase to the latest commit.

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: remove redundant import misc
......................................................................

Patch Set 2: Verified; Looks good to me, approved

simple rebase. thanks.

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: remove redundant import misc
......................................................................

remove redundant import misc

there is already "import storage.misc as misc"

Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Signed-off-by: ShaoHe Feng 
---
M vdsm/supervdsmServer.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iacb0b7d4510a2f44cdb3041c4ff10293e6878458
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Hunt Xu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server