Change in vdsm[master]: logging: add and use new devel logger

Yaniv Bronhaim has posted comments on this change.

Change subject: logging: add and use new devel logger
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 142: 
Line 143: 
Line 144: _devel.warning(
Line 145:     "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use
"
Line 146:     "vdsm.jsonrpcvdscli")
>  Please remove this change from the patch, as devel logger is not good
> solut 
I really don't understand your expectation. I suggest to keep it and focus
on the areas that imports vdscli. for 4.0 please remove this warning at all, leave it only
on master and we'll move forward with replacing usages. in 4.1 we will remove vdscli
at all
Line 147: 
Line 148: 
Line 149: if __name__ == '__main__':
Line 150:     print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes