Dan Kenigsberg has uploaded a new change for review.
Change subject: getCaps: differentiate between bridges and nets ......................................................................
getCaps: differentiate between bridges and nets
Since we have bridgeless networks, bridges are no longer equivalent to networks, and should be reported separately.
Change-Id: If7dd0b6761d501f4300199bee02c798e6f38076b Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/netinfo.py 1 file changed, 18 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/6644/1 -- To view, visit http://gerrit.ovirt.org/6644 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If7dd0b6761d501f4300199bee02c798e6f38076b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: getCaps: differentiate between bridges and nets ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6644 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If7dd0b6761d501f4300199bee02c798e6f38076b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: getCaps: differentiate between bridges and nets ......................................................................
Patch Set 1: I would prefer that you didn't submit this
should mention 843498
-- To view, visit http://gerrit.ovirt.org/6644 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If7dd0b6761d501f4300199bee02c798e6f38076b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: BZ#843498 getCaps: differentiate between bridges and nets ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6644 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If7dd0b6761d501f4300199bee02c798e6f38076b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: BZ#843498 getCaps: differentiate between bridges and nets ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/6644 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If7dd0b6761d501f4300199bee02c798e6f38076b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com
Igor Lvovsky has submitted this change and it was merged.
Change subject: BZ#843498 getCaps: differentiate between bridges and nets ......................................................................
BZ#843498 getCaps: differentiate between bridges and nets
Since we have bridgeless networks, bridges are no longer equivalent to networks, and should be reported separately.
Change-Id: If7dd0b6761d501f4300199bee02c798e6f38076b Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/netinfo.py 1 file changed, 18 insertions(+), 3 deletions(-)
Approvals: Igor Lvovsky: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6644 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: If7dd0b6761d501f4300199bee02c798e6f38076b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com
vdsm-patches@lists.fedorahosted.org