Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64

[Pradipta Kumar Banerjee]

Pradipta Banerjee has uploaded a new change for review.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................

utils.py: Add hostUUID retrieval support for KVM on PPC64

Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Signed-off-by: Pradipta Kr. Banerjee <bpradip(a)in.ibm.com&gt;
---
M vdsm/utils.py
1 file changed, 16 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/8637/1

diff --git a/vdsm/utils.py b/vdsm/utils.py
index 0dbb342..80582d4 100644
--- a/vdsm/utils.py
+++ b/vdsm/utils.py
@@ -37,6 +37,7 @@
 import functools
 import stat
 import glob
+import platform
 
 import ethtool
 
@@ -701,19 +702,23 @@
             with open(constants.P_VDSM_NODE_ID) as f:
                 __hostUUID = f.readline().replace("\n", "")
         else:
-            p = subprocess.Popen([constants.EXT_SUDO,
+            arch = platform.machine()
+            if arch == 'x86_64':
+                p = subprocess.Popen([constants.EXT_SUDO,
                                   constants.EXT_DMIDECODE, "-s",
"system-uuid"],
-                                 close_fds=True, stdin=subprocess.PIPE,
-                                 stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-            out, err = p.communicate()
-            out = '\n'.join( line for line in out.splitlines()
+                                  close_fds=True, stdin=subprocess.PIPE,
+                                  stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+                out, err = p.communicate()
+                out = '\n'.join( line for line in out.splitlines()
                              if not line.startswith('#') )
 
-            if p.returncode == 0 and 'Not' not in out:
-                #Avoid error string - 'Not Settable' or 'Not Present'
-                __hostUUID = out.strip()
-            else:
-                logging.warning('Could not find host UUID.')
+                if p.returncode == 0 and 'Not' not in out:
+                    #Avoid error string - 'Not Settable' or 'Not
Present'
+                    __hostUUID = out.strip()
+            elif arch == 'ppc64':
+                if os.path.exists('/proc/device-tree/system-id'):
+                    #eg. output IBM,03061C14A
+                    __hostUUID =
file('/proc/device-tree/system-id').readline().replace(",",
"")
 
             try:
                 mac = sorted(_getAllMacs())[0]
@@ -724,6 +729,7 @@
             if __hostUUID != "None":
                 __hostUUID += "_" + mac
             else:
+                logging.warning('Could not find host UUID')
                 __hostUUID = "_" + mac
     except:
         logging.error("Error retrieving host UUID", exc_info=True)


--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

minor comments.

....................................................
File lib/vdsm/utils.py
Line 687:             with open(constants.P_VDSM_NODE_ID) as f:
Line 688:                 __hostUUID = f.readline().replace("\n", "")
Line 689:         else:
Line 690:             arch = platform.machine()
Line 691:             if arch == 'x86_64':
in host-deploy it is:

 if arch in ('x86_64', 'i686'):

not sure we want to keep support for i686, it is used mostly for fake I think.
Line 692:                 p = subprocess.Popen([constants.EXT_SUDO,
Line 693:                                       constants.EXT_DMIDECODE, "-s",
Line 694:                                       "system-uuid"],
Line 695:                                      close_fds=True, stdin=subprocess.PIPE,


Line 707:             elif arch in ('ppc', 'ppc64'):
Line 708:                 #eg. output IBM,03061C14A
Line 709:                 if os.path.exists('/proc/device-tree/system-id'):
Line 710:                     with open('/proc/device-tree/system-id') as f:
Line 711:                         systemId = f.readline()
any reason for this temp variable?
Line 712:                         __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713: 
Line 714:             if legacy:
Line 715:                 try:


-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Vitor de Lima has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-HasComments: No

Itamar Heim has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 1:

i think you just need to submit a newer patch

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-HasComments: No

Vitor de Lima has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 1:

How can I become the owner of this change? Should it be abandoned and resubmitted?

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-HasComments: No

[Pradipta Kumar Banerjee]

Pradipta Banerjee has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;

Vitor de Lima has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 1:

(2 comments)

....................................................
File vdsm/utils.py
Line 702:             with open(constants.P_VDSM_NODE_ID) as f:
Line 703:                 __hostUUID = f.readline().replace("\n", "")
Line 704:         else:
Line 705:             arch = platform.machine()
Line 706:             if arch == 'x86_64':
In another review it was suggested that an Enum could be used instead of the explict
platform name.
Line 707:                 p = subprocess.Popen([constants.EXT_SUDO,
Line 708:                                   constants.EXT_DMIDECODE, "-s",
"system-uuid"],
Line 709:                                   close_fds=True, stdin=subprocess.PIPE,
Line 710:                                   stdout=subprocess.PIPE,
stderr=subprocess.PIPE)


Line 717:                     __hostUUID = out.strip()
Line 718:             elif arch == 'ppc64':
Line 719:                 if os.path.exists('/proc/device-tree/system-id'):
Line 720:                     #eg. output IBM,03061C14A
Line 721:                     __hostUUID =
file('/proc/device-tree/system-id').readline().replace(",",
"")
In the system-id file there is a null character in the end of the string, in other
situations this can break the oVirt engine. I think this character should be removed after
the readline().
Line 722: 
Line 723:             try:
Line 724:                 mac = sorted(_getAllMacs())[0]
Line 725:             except:


-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-HasComments: Yes

Itamar Heim has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 1:

ping?

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 5: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


utils.py: Add hostUUID retrieval support for KVM on PPC64

Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Signed-off-by: Pradipta Kr. Banerjee <bpradip(a)in.ibm.com&gt;
Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Reviewed-on: http://gerrit.ovirt.org/8637
Reviewed-by: Francesco Romani <fromani(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-by: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Tested-by: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
---
M lib/vdsm/utils.py
1 file changed, 25 insertions(+), 14 deletions(-)

Approvals:
  Vitor de Lima: Verified
  Gustavo Frederico Temple Pedrosa: Verified; Looks good to me, but someone else must
approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Vitor de Lima has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 4:

(1 comment)

....................................................
File lib/vdsm/utils.py
Line 705:                 else:
Line 706:                     logging.warning('Could not find host UUID.')
Line 707:             elif arch in ('ppc', 'ppc64'):
Line 708:                 #eg. output IBM,03061C14A
Line 709:                 if os.path.exists('/proc/device-tree/system-id'):
Done
Line 710:                     with open('/proc/device-tree/system-id') as f:
Line 711:                         systemId = f.readline()
Line 712:                         __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713: 


-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6666/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5773/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6579/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Vitor de Lima has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 5: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6662/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5769/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6575/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Itamar Heim has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 4:

also, gerrit 2.8 may have some improvements on copying scores during rebases - we'll
see...

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Vitor de Lima has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 2:

(1 comment)

....................................................
File lib/vdsm/utils.py
Line 706:                     logging.warning('Could not find host UUID.')
Line 707:             elif arch == 'ppc64':
Line 708:                 if os.path.exists('/proc/device-tree/system-id'):
Line 709:                     #eg. output IBM,03061C14A
Line 710:                     systemId =
file('/proc/device-tree/system-id').readline()
Done
Line 711: 
Line 712:                     __hostUUID =
systemId.rstrip('\0').replace(",", "")
Line 713: 
Line 714:             if legacy:


-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Vitor de Lima has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 4:

(1 comment)

....................................................
File lib/vdsm/utils.py
Line 705:                 else:
Line 706:                     logging.warning('Could not find host UUID.')
Line 707:             elif arch in ('ppc', 'ppc64'):
Line 708:                 #eg. output IBM,03061C14A
Line 709:                 if os.path.exists('/proc/device-tree/system-id'):
There still an -admittedly, tiny- window right here between those two lines.
Maybe is simpler and safer something like

try:
  with open('/proc/device-tree/system-id') as f:
    systemId = f.readline()
    __hostUUID = systemId.rstrip('\0').replace(',', '')
except IOError:
  logging.warning(...)

However, even if we acknowledge this as flaw, all the code all around is similar, so this
is probably better addressed in a different change.
Line 710:                     with open('/proc/device-tree/system-id') as f:
Line 711:                         systemId = f.readline()
Line 712:                         __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713: 


-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6663/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5770/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6576/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 3:

(1 comment)

....................................................
File lib/vdsm/utils.py
Line 707:             elif arch in ('ppc', 'ppc64'):
Line 708:                 #eg. output IBM,03061C14A
Line 709:                 if os.path.exists('/proc/device-tree/system-id'):
Line 710:                     with open('/proc/device-tree/system-id') as f:
Line 711:                         systemId = f.readline()
:)))

 __hostUUID = f.readline().rstrip(
     '\0'
 ).replace(',', '')

not that it is important....
Line 712:                         __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713: 
Line 714:             if legacy:
Line 715:                 try:


-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 2:

>  Alon, would you use -1 to make it clear when you would not like to
> see a patch posted as it is? 
well, we discussed that in the past.

-1 is not a marker... it is strong rejection.

why can't it used as a marker, let's say the author just rebase his patch, so -1
is gone, and now we are in chase of marking -1 all over to avoid merge, what if someone is
not available?

I think the interpretation should be modified, but not that important to discuss that
again.

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Vitor de Lima has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 3:

(2 comments)

....................................................
File lib/vdsm/utils.py
Line 687:             with open(constants.P_VDSM_NODE_ID) as f:
Line 688:                 __hostUUID = f.readline().replace("\n", "")
Line 689:         else:
Line 690:             arch = platform.machine()
Line 691:             if arch == 'x86_64':
Done
Line 692:                 p = subprocess.Popen([constants.EXT_SUDO,
Line 693:                                       constants.EXT_DMIDECODE, "-s",
Line 694:                                       "system-uuid"],
Line 695:                                      close_fds=True, stdin=subprocess.PIPE,


Line 707:             elif arch in ('ppc', 'ppc64'):
Line 708:                 #eg. output IBM,03061C14A
Line 709:                 if os.path.exists('/proc/device-tree/system-id'):
Line 710:                     with open('/proc/device-tree/system-id') as f:
Line 711:                         systemId = f.readline()
It is just to not exceed the 80 columns limit that is enforced in the project.
Line 712:                         __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713: 
Line 714:             if legacy:
Line 715:                 try:


-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 3:

+1 is served as a positive notice.

how reviewer should express 'strong rejection' if all he have is -1? hence -1 is
the strongest that it can get, a notice to maintainer that something is should be
addressed.

anyway, not that it is important right now.

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 3:

Alon, if someone rebases a patch without attending to all comments therein, he is at
fault. -1 serves as a notice to the author and to me, that not all is well in the current
version of the patch, and that the reviewer would not be happy if the code is merged
as-is. It should not be interpreted as a "strong rejection".

(You are correct that this is not the proper venue to discuss that)

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Michal Skrivanek has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 2: Code-Review-1

Alon, would you use -1 to make it clear when you would not like to see a patch posted as
it is?

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 2:

(1 comment)

....................................................
File lib/vdsm/utils.py
Line 706:                     logging.warning('Could not find host UUID.')
Line 707:             elif arch == 'ppc64':
Line 708:                 if os.path.exists('/proc/device-tree/system-id'):
Line 709:                     #eg. output IBM,03061C14A
Line 710:                     systemId =
file('/proc/device-tree/system-id').readline()
do not use file, it leaks.

take from host-deploy:

        elif arch in ('ppc', 'ppc64'):
            #eg. output IBM,03061C14A
            if os.path.exists('/proc/device-tree/system-id'):
                with open('/proc/device-tree/system-id') as f:
                    vdsmId = f.readline().rstrip('\0').replace(',',
'')
Line 711: 
Line 712:                     __hostUUID =
systemId.rstrip('\0').replace(",", "")
Line 713: 
Line 714:             if legacy:


-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6645/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5752/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6558/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Itamar Heim has posted comments on this change.

Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
......................................................................


Patch Set 1:

ping

-- 
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br&gt;
Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-HasComments: No