Change in vdsm[master]: NetReload: netmodels for addNetwork

Giuseppe Vallarelli has posted comments on this change.

Change subject: NetReload: netmodels for addNetwork
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 63:         if self.configWriter:
Line 64:             self.configWriter = None
Line 65:             self._libvirtAdded = set()
Line 66: 
Line 67:     def configureBridge(self, bridge, network=None, **opts):
All the different configureX use internal attributes of the object they're trying to
configure, what if all the entities have a proper configure method, what do you think?
Line 68:         try:
Line 69:             ipaddr = bridge.ip.inet.address
Line 70:             netmask = bridge.ip.inet.netmask
Line 71:             gateway = bridge.ip.inet.gateway


--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server