Change in vdsm[master]: added a very very simple test for the function filterXmlChar...

Yeela Kaplan has uploaded a new change for review.

Change subject: added a very very simple test for the function filterXmlChars in the
guestIF module
......................................................................

added a very very simple test for the function filterXmlChars in the guestIF module

Change-Id: I8aaef976320ed27428d8952c23d7fbeb8f4f156a
---
M tests/Makefile.am
A tests/guestIF_test.py
2 files changed, 37 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/3141/1
--
To view, visit http://gerrit.ovirt.org/3141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8aaef976320ed27428d8952c23d7fbeb8f4f156a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: added a very very simple test for the function filterXmlChars in the
guestIF module
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

In general looks good. There are a couple of infrastructure problems (but they're not
specific to this patch). For example I'd like to have just one command in the
Makefile.am, which means that main.py should import TestGuestIF, but we need to discuss
it.

....................................................
Commit Message
Line 7: added a very very simple test for the function filterXmlChars in the guestIF
module
Given that currently we only have another test, in comparison, it's not "very
very simple", it's just a regular test :-)

--
To view, visit http://gerrit.ovirt.org/3141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8aaef976320ed27428d8952c23d7fbeb8f4f156a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added a very very simple test for the function filterXmlChars in the
guestIF module
......................................................................


Patch Set 1: Verified; Looks good to me, approved

ok, so if it is not horrible, let us take it!

--
To view, visit http://gerrit.ovirt.org/3141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8aaef976320ed27428d8952c23d7fbeb8f4f156a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: added a very very simple test for the function filterXmlChars in the
guestIF module
......................................................................


added a very very simple test for the function filterXmlChars in the guestIF module

Change-Id: I8aaef976320ed27428d8952c23d7fbeb8f4f156a
---
M tests/Makefile.am
A tests/guestIF_test.py
2 files changed, 37 insertions(+), 1 deletion(-)

Approvals:
  Federico Simoncelli: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/3141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8aaef976320ed27428d8952c23d7fbeb8f4f156a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;