Change in vdsm[master]: Fix connectStorageServer doc string

Saggi Mizrahi has uploaded a new change for review.

Change subject: Fix connectStorageServer doc string
......................................................................

Fix connectStorageServer doc string

Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
---
M vdsm/storage/hsm.py
1 file changed, 7 insertions(+), 7 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/1098/1
--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

Sorry, I know that you hate such comments, but first you have a couple of typos and second  if you decided to to fix docstiring (it is very welcome) in function like connectStorageServer I can't find a reason why you didn't fixed it in disconnectStorageServer

....................................................
File vdsm/storage/hsm.py
Line 1787:                         corosponding domains type
corresponding

Line 1790:                         with keys depnding ont the type
ont ???

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 7: Looks good to me, but someone else must approve

I gave you +1, but I think there is no reason to keep this patch stand alone and IMHO you should squash this patch to the next one http://gerrit.ovirt.org/#change,1038.
Anyway, you change here docstring only for connectStorageServer and for disconnectStorageServer you change it in next patch

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

As I wrote in previous patchset:
I gave you +1, but I think there is no reason to keep this patch stand alone and IMHO you should squash this patch to the next one http://gerrit.ovirt.org/#change,1038. Anyway, you change here docstring only for connectStorageServer and for disconnectStorageServer you change it in next patch

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 9: Looks good to me, but someone else must approve

you gentle ignore my comments

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 10: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 11: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 12: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1787:                         corresponding domains type
Did you mean "The connection type, sometimes expressed as the corresponding domain type" ?

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 13: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 13: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix connectStorageServer doc string
......................................................................

Patch Set 13: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix connectStorageServer doc string
......................................................................

Fix connectStorageServer doc string

Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
---
M vdsm/storage/hsm.py
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Federico Simoncelli: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi