6:48 a.m.
Eduardo has uploaded a new change for review.
Change subject: Split removeNameFormat functionality.
......................................................................
Split removeNameFormat functionality.
Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
---
M vdsm/storage/image.py
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/441/1
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
2:22 a.m.
New subject: Change in vdsm[master]: Split deletedVolumeName functionality
Dan Kenigsberg has posted comments on this change.
Change subject: Split deletedVolumeName functionality
......................................................................
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
2:22 a.m.
New subject: Change in vdsm[master]: Split deletedVolumeName functionality
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Split deletedVolumeName functionality
......................................................................
Split deletedVolumeName functionality
Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
---
M vdsm/storage/image.py
1 file changed, 10 insertions(+), 6 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
3:08 p.m.
New subject: Change in vdsm[master]: Split deletedVolumeName functionality.
Dan Kenigsberg has posted comments on this change.
Change subject: Split deletedVolumeName functionality.
......................................................................
Patch Set 3: Verified
ticking Verified for you.
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
3:48 a.m.
New subject: Change in vdsm[master]: Split deletedVolumeName functionality.
Igor Lvovsky has posted comments on this change.
Change subject: Split deletedVolumeName functionality.
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
2:10 a.m.
New subject: Change in vdsm[master]: Split deletedVolumeName functionality.
Igor Lvovsky has posted comments on this change.
Change subject: Split deletedVolumeName functionality.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/image.py
Line 1054: # Step 4: Rename successor_MERGE to successor
the -2 is only because gerrit restriction to break your +2
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
5:52 a.m.
New subject: Change in vdsm[master]: Split deletedVolumeName functionality.
Dan Kenigsberg has posted comments on this change.
Change subject: Split deletedVolumeName functionality.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/image.py
Line 1054: # Step 4: Rename successor_MERGE to successor
I'm not sure this is so unrelated. In any case, -2 is too dramatic for this!
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
5:03 a.m.
New subject: Change in vdsm[master]: Split deletedVolumeName functionality.
Igor Lvovsky has posted comments on this change.
Change subject: Split deletedVolumeName functionality.
......................................................................
Patch Set 2: Do not submit
(1 inline comment)
....................................................
File vdsm/storage/image.py
Line 1054: # Step 4: Rename successor_MERGE to successor
This not related to the patch. Please move it to proper patch
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
1:31 p.m.
New subject: Change in vdsm[master]: Split deletedVolumeName functionality.
Dan Kenigsberg has posted comments on this change.
Change subject: Split deletedVolumeName functionality.
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
11:29 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Split removeNameFormat functionality.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/image.py
Line 248: def removeNameFormat(self, uuid):
function name is not clear it all, and its docstring makes it worse. function is not
expected to be public, so the name should show it (_).
how about _deletedVolumeName()?
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
6:58 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Split removeNameFormat functionality.
......................................................................
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4513
days inactive
4524
days old
vdsm-patches@lists.fedorahosted.org
10 comments
3 participants
participants (3)
-
Dan Kenigsberg -
ewarszaw＠redhat.com -
Igor Lvovsky