Change in vdsm[master]: vdsm.spec: pyflakes/python-pep8 BuildRequirement

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsm.spec: pyflakes/python-pep8 BuildRequirement
......................................................................

vdsm.spec: pyflakes/python-pep8 BuildRequirement

pyflakes and python-pep8 are not default RHEL packages.
This patch will move it for non rhel system requirements.

Change-Id: Ieaf21db9542ae3c9e107a94f64e0e52c7a7e62c1
Signed-off-by: Douglas Schilling Landgraf 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/8940/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 37f37a3..c117ee5 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -35,9 +35,7 @@

BuildRequires: python
 BuildRequires: python-devel
-BuildRequires: pyflakes
 BuildRequires: python-nose
-BuildRequires: python-pep8

# BuildRequires needed by the tests during the build
 BuildRequires: python-ethtool
@@ -54,6 +52,8 @@
 %endif

%if !0%{?rhel}
+BuildRequires: pyflakes
+BuildRequires: python-pep8
 BuildRequires: systemd-units
 %endif

--
To view, visit http://gerrit.ovirt.org/8940
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieaf21db9542ae3c9e107a94f64e0e52c7a7e62c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: pyflakes/python-pep8 BuildRequirement
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/8940
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaf21db9542ae3c9e107a94f64e0e52c7a7e62c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: pyflakes/python-pep8 BuildRequirement
......................................................................

Patch Set 1: Looks good to me, approved

Ok... until we have them in el6.
Please make sure to use pyflakes & pep8 if you contribute code.

--
To view, visit http://gerrit.ovirt.org/8940
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaf21db9542ae3c9e107a94f64e0e52c7a7e62c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm.spec: pyflakes/python-pep8 BuildRequirement
......................................................................

vdsm.spec: pyflakes/python-pep8 BuildRequirement

pyflakes and python-pep8 are not default RHEL packages.
This patch will move it for non rhel system requirements.

Change-Id: Ieaf21db9542ae3c9e107a94f64e0e52c7a7e62c1
Signed-off-by: Douglas Schilling Landgraf 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/8940
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaf21db9542ae3c9e107a94f64e0e52c7a7e62c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli