Nir Soffer has uploaded a new change for review.
Change subject: lvm: Decrease number of retries before failing ......................................................................
lvm: Decrease number of retries before failing
Previously we configured lvm to stop accessing a device during an lvm opoeration after 3 errors. This can cause lvm to block 3 times when trying to access inaccessible device. With current iscsi settings, each block can be 120 seconds, total 360 seconds. We have seen lvm block for couple of minutes in such cases.
The retries seems uneeded when working with multiple paths, as multipath already retry all available paths after SCSI errors on one path. However when working with single path, multipath should fail after one try.
According to lvm developer this may decrease the time lvm is blocked when devices are not accesible.
(Not tested yet)
Change-Id: I5d11abaaff45ce86e88c6589264e162318ac1f1d Relates-To: https://bugzilla.redhat.com/880738 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm/storage/lvm.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/32356/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 86edf55..f760f7b 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -106,7 +106,7 @@ preferred_names = ["^/dev/mapper/"] ignore_suspended_devices=1 write_cache_state=0 -disable_after_error_count=3 +disable_after_error_count=1 obtain_device_list_from_udev=0 %s }
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Decrease number of retries before failing ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11270/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12212/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12059/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: lvm: Decrease number of retries before failing ......................................................................
Patch Set 1:
Ben Marzinski (mulipath developer) suggest that we move the retries to multipath, since we have more control there.
However, with the current version of multipath, we cannot control the retries in the devies level, because we don't have yet a configuration option to match all devices and override certain options.
https://bugzilla.redhat.com/show_bug.cgi?id=880738#c31
Nir Soffer has posted comments on this change.
Change subject: lvm: Decrease number of retries before failing ......................................................................
Patch Set 1:
Need testing
Jenkins CI RO has posted comments on this change.
Change subject: lvm: Decrease number of retries before failing ......................................................................
Patch Set 1:
Abandoned due to no activity - please restore if still relevant
vdsm-patches@lists.fedorahosted.org