From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Don't configure firewalld unless required in vdsm.conf
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/75099/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
PS6, Line 265: '
why's the apostrophe? (It may seem that I'm in a crusade against them...)
https://gerrit.ovirt.org/#/c/75099/6/lib/vdsm/tool/configurators/firewall...
File lib/vdsm/tool/configurators/firewalld.py:
Line 67: _add_to_required_services('vdsm.gluster.api', ('glusterfs',
'samba', 'nfs'))
Line 68: _add_to_required_services('cockpit', ('cockpit',))
Line 69:
Line 70:
Line 71: def configure():
to rephrase my comment:
if for some reason someone runs
vdsm-tool configure
without checking
vdsm-tool is-configured
first, your could would configure firewalld regardless of the value in vdsm.conf.
Line 72: if service_status('firewalld') == 1:
Line 73: service_start('firewalld')
Line 74:
Line 75: fw_client = FirewallClient()
--
To view, visit
https://gerrit.ovirt.org/75099
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c46eb2915ef3cb31d4a494070db7ac430672601
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes