Change in vdsm[master]: add xmlrpcTests for cpu pinning

Royce Lv has uploaded a new change for review.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

add xmlrpcTests for cpu pinning

Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Signed-off-by: Royce Lv
---
M tests/functional/xmlrpcTests.py
M tests/vdsClientTests.py
2 files changed, 40 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/8412/1

diff --git a/tests/functional/xmlrpcTests.py b/tests/functional/xmlrpcTests.py
index 9c865db..2684d0f 100644
--- a/tests/functional/xmlrpcTests.py
+++ b/tests/functional/xmlrpcTests.py
@@ -174,3 +174,33 @@
                 destroyResult = self.s.destroy(VMID)

self.assertVdsOK(destroyResult)
+
+    def testCpuPin(self):
+        self.skipNoKVM()
+
+        def assertVMAndGuestUp():
+            self.assertVmUp(VMID)
+            self.assertGuestUp(VMID)
+
+        VMID = '77777777-ffff-3333-aaaa-222222222222'
+
+        with kernelBootImages() as (kernelPath, initramfsPath):
+            conf = {'display': 'vnc',
+                    'kernel': kernelPath,
+                    'initrd': initramfsPath,
+                    'kernelArgs': 'rd.break=cmdline rd.shell rd.skipfsck',
+                    'kvmEnable': 'true',
+                    'memSize': '256',
+                    'vmId': VMID,
+                    'vmName': 'vdsm_testPinVM',
+                    'vmType': 'kvm',
+                    'cpuPinning': {'emulator': '0', '0': '1'}}
+
+            try:
+                self.assertVdsOK(self.s.create(conf))
+                # wait 65 seconds for VM to come up until timeout
+                self.retryAssert(assertVMAndGuestUp, 65, 1)
+            finally:
+                destroyResult = self.s.destroy(VMID)
+
+        self.assertVdsOK(destroyResult)
diff --git a/tests/vdsClientTests.py b/tests/vdsClientTests.py
index abf3242..57e6e74 100644
--- a/tests/vdsClientTests.py
+++ b/tests/vdsClientTests.py
@@ -118,3 +118,13 @@
         allArgs[-1] = 'cpuPinning={0:1,1:0}'
         r4 = serv.do_create(['/dev/null'] + allArgs)
         self.assertNotEquals(r4, expectResult)
+
+        # test just pin emulator
+        allArgs[-1] = "cpuPinning={emulator:1-3}"
+        r5 = serv.do_create(['/dev/null'] + allArgs)
+        self.assertEquals(r5['cpuPinning'],{'emulator':'1-3'})
+
+        # test pin emultor and vcpu
+        allArgs[-1] = "cpuPinning={emulator:1-3,1:0}"
+        r6 = serv.do_create(['/dev/null'] + allArgs)
+        self.assertEquals(r6['cpuPinning'],{'emulator':'1-3','1':'0'})

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv

Zhou Zheng Sheng has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File tests/functional/xmlrpcTests.py
Line 202:                 self.retryAssert(assertVMAndGuestUp, 65, 1)
Line 203:             finally:
Line 204:                 destroyResult = self.s.destroy(VMID)
Line 205: 
Line 206:         self.assertVdsOK(destroyResult)
You may notice there is duplicate code for starting a test VM, so I extract a method for this. Could you have a look at gerrit.ovirt.org/#/c/8183/ ? I add a method named "_runVMKernelBoot" in this file. Would you give me some comments on that new method? If you think it's useful, I can split it from my 8183 and submit a separate patch.

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Zhou Zheng Sheng

Zhou Zheng Sheng has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File tests/functional/xmlrpcTests.py
Line 202:                 self.retryAssert(assertVMAndGuestUp, 65, 1)
Line 203:             finally:
Line 204:                 destroyResult = self.s.destroy(VMID)
Line 205: 
Line 206:         self.assertVdsOK(destroyResult)
I split the kernel boot related method to a separate patch, the url is http://gerrit.ovirt.org/#/c/8414/ .

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Zhou Zheng Sheng

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/242/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/276/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/242/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/276/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Doron Fediuck has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/265/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/299/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/265/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/299/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Royce Lv has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

Inline comment is just a typo in a comment.

....................................................
File tests/vdsClientTests.py
Line 123:         allArgs[-1] = "cpuPinning={emulator:1-3}"
Line 124:         r5 = serv.do_create(['/dev/null'] + allArgs)
Line 125:         self.assertEquals(r5['cpuPinning'], {'emulator': '1-3'})
Line 126: 
Line 127:         # test pin emultor and vcpu
s/emultor/emulator
Line 128:         allArgs[-1] = "cpuPinning={emulator:1-3,1:0}"
Line 129:         r6 = serv.do_create(['/dev/null'] + allArgs)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/308/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/274/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/274/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/308/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

I don't see the difference compared to patch set 3 so I've added the same comment.

....................................................
File tests/vdsClientTests.py
Line 123:         allArgs[-1] = "cpuPinning={emulator:1-3}"
Line 124:         r5 = serv.do_create(['/dev/null'] + allArgs)
Line 125:         self.assertEquals(r5['cpuPinning'], {'emulator': '1-3'})
Line 126: 
Line 127:         # test pin emultor and vcpu
s/emultor/emulator
Line 128:         allArgs[-1] = "cpuPinning={emulator:1-3,1:0}"
Line 129:         r6 = serv.do_create(['/dev/null'] + allArgs)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Royce Lv has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Doron Fediuck has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 4:

Fixing the typo Ewould suggested is still needed.

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Royce Lv has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 4:

Sorry, haven't noticed this comment, will update immediately

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/500/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/465/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/465/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/500/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Doron Fediuck has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Royce Lv has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 5: Verified

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Zhou Zheng Sheng has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 5: (1 inline comment)

....................................................
File tests/vdsClientTests.py
Line 126: 
Line 127:         # test pin emulator and vcpu
Line 128:         allArgs[-1] = "cpuPinning={emulator:1-3,1:0}"
Line 129:         r6 = serv.do_create(['/dev/null'] + allArgs)
Line 130:         self.assertEquals(r6['cpuPinning'], {'emulator': '1-3', '1': '0'})
Keeping "r1", "r2", ... is not very useful here. I think we can replace all "r1", "r2", ... by "r".

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Doron Fediuck has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 5: (1 inline comment)

....................................................
File tests/vdsClientTests.py
Line 126: 
Line 127:         # test pin emulator and vcpu
Line 128:         allArgs[-1] = "cpuPinning={emulator:1-3,1:0}"
Line 129:         r6 = serv.do_create(['/dev/null'] + allArgs)
Line 130:         self.assertEquals(r6['cpuPinning'], {'emulator': '1-3', '1': '0'})
Since Royce is simply continuing the existing pattern
I see nothing wrong with submitting a separate patch for such a change, if indeed required.

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/743/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/708/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/708/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/743/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6: Looks good to me, but someone else must approve

Just a rebase, giving +1 again

--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Noam Slomianko 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6:

ping

Itamar Heim has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6:

so, should be abandoned?

Martin Polednik has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6:

This patch in its current form without rebase and a bit of work wouldn't test anything: we would only see if the initial configuration's XML would pass the libvirt create call.

I can look into it if such test makes sense but verification that VM's vCPU really runs on specified physical CPU/core might not be trivial.

Itamar Heim has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6:

ping

Francesco Romani has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6:

same as per 8445, but with smaller gain IMHO. Probably worth squashing in just one (new) patch.

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6: Code-Review+1

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6: Code-Review-1

Vinzenz, this change does not require a casual review, but a serious rebase and a complete re-ownership.

Itamar Heim has posted comments on this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Patch Set 6:

ping

Itamar Heim has abandoned this change.

Change subject: add xmlrpcTests for cpu pinning
......................................................................

Abandoned

abandon - no activity. please restore if relevant