From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Make mailbox_test compatible with pytest
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
-1 for visibility only
https://gerrit.ovirt.org/#/c/78589/6/tests/storage/mailbox_test.py
File tests/storage/mailbox_test.py:
PS6, Line 100:
I don't remember what this test is really for, but the mailer.run() call smells crucial here. Are you sure you are not simplifying the test too much?
--
To view, visit
https://gerrit.ovirt.org/78589
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67aaf03e382c730757e8d3d208267d177ea325c6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Adam Litke
alitke@redhat.com
Gerrit-Reviewer: Ala Hino
ahino@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Freddy Rolland
frolland@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk
mlipchuk@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes