Change in vdsm[master]: [WIP] BZ#745510 Fedora rpmlint fixes

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: [WIP] BZ#745510 Fedora rpmlint fixes
......................................................................

[WIP] BZ#745510 Fedora rpmlint fixes

Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
---
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/configNetwork.py
M vdsm/storage/Makefile.am
M vdsm/supervdsmServer.py
5 files changed, 5 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/261/1
--
To view, visit http://gerrit.ovirt.org/261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: BZ#745510 Fedora rpmlint fixes

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#745510 Fedora rpmlint fixes
......................................................................


BZ#745510 Fedora rpmlint fixes

In this patch:
* Remove shebang from the non-script python files
* Require iscsi-initiator-utils >= 6.2.0.872-14 (BZ#442980)
* Move the lvm rules to the appropriate path
* Use the %ghost keyword for the /var/run paths
* vdsm-libvirt-logrotate doesn't need to be executable
* Require only the saslpasswd2 binary instead of the sasl package

Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
---
M vds_bootstrap/vds_bootstrap.py
M vds_bootstrap/vds_bootstrap_complete.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/configNetwork.py
M vdsm/storage/Makefile.am
M vdsm/supervdsmServer.py
M vdsm_cli/vdsClient.py
M vdsm_reg/rhevm.py
9 files changed, 11 insertions(+), 27 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#745510 Fedora rpmlint fixes

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#745510 Fedora rpmlint fixes
......................................................................


Patch Set 8: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#745510 Fedora rpmlint fixes

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: BZ#745510 Fedora rpmlint fixes
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm.spec.in
Line 138:                  %{buildroot}/lib/udev/rules.d/12-vdsm-lvm.rules
Automake is not capable to install any file inside /lib (it fails the distcheck; I talked
about this with Jim Meyering) because at the moment that location is distribution-specific
(therefore here it is). With the growing of more and more standard files going there
(udev, systemd, etc...) automake might implement it.

--
To view, visit http://gerrit.ovirt.org/261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#745510 Fedora rpmlint fixes

Saggi Mizrahi has posted comments on this change.

Change subject: BZ#745510 Fedora rpmlint fixes
......................................................................


Patch Set 7: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
Commit Message
Line 7: BZ#745510 Fedora rpmlint fixes
Could you please specify what you did and why in bullets?

--
To view, visit http://gerrit.ovirt.org/261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#745510 Fedora rpmlint fixes

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#745510 Fedora rpmlint fixes
......................................................................


Patch Set 7: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm.spec.in
Line 138:                  %{buildroot}/lib/udev/rules.d/12-vdsm-lvm.rules
I don't really mind, by why was this moved here? is it so very  rpm-specific?

--
To view, visit http://gerrit.ovirt.org/261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] BZ#745510 Fedora rpmlint fixes
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm.spec.in
Line 341: /lib/udev/rules.d/12-vdsm-lvm.rules
this should be considered what udev(1) calls a "default rule"?

--
To view, visit http://gerrit.ovirt.org/261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;