Change in vdsm[master]: The method readMultipathConf should return a list

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: The method readMultipathConf should return a list
......................................................................

The method readMultipathConf should return a list

For backward compatibility with the previous implementation (using sudo
and execCmd, see commit f869064) the readMultipathConf method should
return a list of lines.

Signed-off-by: Federico Simoncelli 
Change-Id: Icf1654e752698d1dbb41c09a8d409784570a9fcd
---
M vdsm/supervdsmServer.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/3863/1
--
To view, visit http://gerrit.ovirt.org/3863
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf1654e752698d1dbb41c09a8d409784570a9fcd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

Eyal Edri has posted comments on this change.

Change subject: The method readMultipathConf should return a list
......................................................................

Patch Set 1: Verified

not shutting down in loop anymore,

though i still can't connect with vdsClient remotly to the host running vdsm (gets timeout), not sure if it's relevant to this bug.

--
To view, visit http://gerrit.ovirt.org/3863
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1654e752698d1dbb41c09a8d409784570a9fcd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: The method readMultipathConf should return a list
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3863
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1654e752698d1dbb41c09a8d409784570a9fcd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: The method readMultipathConf should return a list
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3863
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1654e752698d1dbb41c09a8d409784570a9fcd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: The method readMultipathConf should return a list
......................................................................

The method readMultipathConf should return a list

For backward compatibility with the previous implementation (using sudo
and execCmd, see commit f869064) the readMultipathConf method should
return a list of lines.

Signed-off-by: Federico Simoncelli 
Change-Id: Icf1654e752698d1dbb41c09a8d409784570a9fcd
---
M vdsm/supervdsmServer.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Eyal Edri: Verified
  Saggi Mizrahi: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3863
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf1654e752698d1dbb41c09a8d409784570a9fcd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: The method readMultipathConf should return a list
......................................................................

Patch Set 1:

btw, there should be a unit test for this. any takers?

--
To view, visit http://gerrit.ovirt.org/3863
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1654e752698d1dbb41c09a8d409784570a9fcd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Saggi Mizrahi