Eduardo has uploaded a new change for review.
Change subject: Revert "hsm: always check validateNotSPM when disconnecting from a pool" ......................................................................
Revert "hsm: always check validateNotSPM when disconnecting from a pool"
This reverts commit 185872e5e03999ed7376099d1c8b1a4044cfa5bb.
Change-Id: I791f626e31c9929d687d181b2d7fd43e1d2b155d Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/13926/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index ae35b11..f3a702e 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1026,12 +1026,12 @@ self.validateNotSPM(spUUID)
vars.task.getExclusiveLock(STORAGE, spUUID) - pool = self.getPool(spUUID) + self.validateNotSPM(spUUID)
+ pool = self.getPool(spUUID) return self._disconnectPool(pool, hostID, scsiKey, remove)
def _disconnectPool(self, pool, hostID, scsiKey, remove): - self.validateNotSPM(pool.spUUID) res = pool.disconnect() del self.pools[pool.spUUID] return res
-- To view, visit http://gerrit.ovirt.org/13926 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I791f626e31c9929d687d181b2d7fd43e1d2b155d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert "hsm: always check validateNotSPM when disconnecting from a pool" ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1967/ (1/2)
-- To view, visit http://gerrit.ovirt.org/13926 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I791f626e31c9929d687d181b2d7fd43e1d2b155d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert "hsm: always check validateNotSPM when disconnecting from a pool" ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2024/ (2/2)
-- To view, visit http://gerrit.ovirt.org/13926 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I791f626e31c9929d687d181b2d7fd43e1d2b155d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert "hsm: always check validateNotSPM when disconnecting from a pool" ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2024/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1967/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/13926 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I791f626e31c9929d687d181b2d7fd43e1d2b155d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Ayal Baron has posted comments on this change.
Change subject: Revert "hsm: always check validateNotSPM when disconnecting from a pool" ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/13926 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I791f626e31c9929d687d181b2d7fd43e1d2b155d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itamar Heim has posted comments on this change.
Change subject: Revert "hsm: always check validateNotSPM when disconnecting from a pool" ......................................................................
Patch Set 1:
ping - still relevant?
Itamar Heim has abandoned this change.
Change subject: Revert "hsm: always check validateNotSPM when disconnecting from a pool" ......................................................................
Abandoned
no reply - abandoning - please restore if still relevant
vdsm-patches@lists.fedorahosted.org