Shu Ming has uploaded a new change for review.
Change subject: Fix the parameter descriptions in create() method of storage domain class ......................................................................
Fix the parameter descriptions in create() method of storage domain class
Change-Id: Ideb1d85c8fc84adf6d3982499a5a04841373e5ab Signed-off-by: Shu Ming shuming@linux.vnet.ibm.com --- M vdsm/storage/blockSD.py M vdsm/storage/localFsSD.py M vdsm/storage/nfsSD.py 3 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/6636/1 -- To view, visit http://gerrit.ovirt.org/6636 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ideb1d85c8fc84adf6d3982499a5a04841373e5ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com
Maor Lipchuk has posted comments on this change.
Change subject: Fix the parameter descriptions in create() method ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6636 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ideb1d85c8fc84adf6d3982499a5a04841373e5ab Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: Fix the parameter descriptions in create() method ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/6636 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ideb1d85c8fc84adf6d3982499a5a04841373e5ab Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the parameter descriptions in create() method ......................................................................
Patch Set 2: Looks good to me, approved
text only, let's take it.
Thanks.
-- To view, visit http://gerrit.ovirt.org/6636 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ideb1d85c8fc84adf6d3982499a5a04841373e5ab Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix the parameter descriptions in create() method ......................................................................
Fix the parameter descriptions in create() method
Fix the parameter descriptions in create() method of storage domain class.
Change-Id: Ideb1d85c8fc84adf6d3982499a5a04841373e5ab Signed-off-by: Shu Ming shuming@linux.vnet.ibm.com --- M vdsm/storage/blockSD.py M vdsm/storage/localFsSD.py M vdsm/storage/nfsSD.py 3 files changed, 9 insertions(+), 3 deletions(-)
Approvals: Shu Ming: Verified Dan Kenigsberg: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6636 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ideb1d85c8fc84adf6d3982499a5a04841373e5ab Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org