[NEW PATCH] Related to 726960 - Restore higher version check. (via gerrit-bot)

New patch submitted by Eduardo Warszawski (ewarszaw(a)redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/927

commit 8918ae22323fe2a829169d41ca67dfc5683cd57d
Author: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Date:   Mon Sep 12 16:17:06 2011 +0300

    Related to 726960 - Restore higher version check.
    
    Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83

diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index bec3beb..55c6b45 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -779,6 +779,8 @@ class StoragePool:
                 #TODO: verify in masterMigrate().
                 if sdUUID == new_msdUUID:
                     raise se.InvalidParameterException("new_msdUUID",
new_msdUUID)
+                #TODO: is this check irrelevant?
+                self.validatePoolMVerHigher(masterVersion)
                 self.masterMigrate(sdUUID, new_msdUUID, masterVersion)
             elif dom.isBackup():
                 dom.unmountMaster()

Change in vdsm[master]: Related to 726960 - Restore higher version check.

Eduardo Warszawski has posted comments on this change.

Change subject: Related to 726960 - Restore higher version check.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

--
To view, visit http://gerrit.usersys.redhat.com/927
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Change in vdsm[master]: Related to 726960 - Restore higher version check.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Related to 726960 - Restore higher version check.
......................................................................


Related to 726960 - Restore higher version check.

This check was removed in commit 85b58b7d9 since the manager
can't send a lower pool version number.
In spite of this some tests stress this condition.
Restoring it in order to fix tests results.

Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
---
M vdsm/storage/sp.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.usersys.redhat.com/927
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Change in vdsm[master]: Related to 726960 - Restore higher version check.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to 726960 - Restore higher version check.
......................................................................


Patch Set 4: Verified; Looks good to me, approved

rebased

--
To view, visit http://gerrit.usersys.redhat.com/927
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Change in vdsm[master]: Related to 726960 - Restore higher version check.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to 726960 - Restore higher version check.
......................................................................


Patch Set 3: Verified; Looks good to me, approved

--
To view, visit http://gerrit.usersys.redhat.com/927
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Change in vdsm[master]: Related to 726960 - Restore higher version check.

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Related to 726960 - Restore higher version check.
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

I don't really like the comment here, but if everyone OK with it you get my ACK

--
To view, visit http://gerrit.usersys.redhat.com/927
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com&gt;

Change in vdsm[master]: Related to 726960 - Restore higher version check.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to 726960 - Restore higher version check.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 7: Related to 726960 - Restore higher version check.
Please explain why this is done: "we formerly failed migrateMaster if masterVersion
arg was lower than the MD one. This semantic was broken by commit XXXX, and we would like
like to restore it, particularly in beta time"

....................................................
File vdsm/storage/sp.py
Line 631:             #TODO: is this check irrelevant?
I like to breathe after #.

--
To view, visit http://gerrit.usersys.redhat.com/927
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;