Eduardo has uploaded a new change for review.
Change subject: FIX spmStop security issue. ......................................................................
FIX spmStop security issue.
SPM_ID pool key is wrote after we are not SPM anymore. (By design.)
Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557 --- M vdsm/storage/sp.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/1866/1 -- To view, visit http://gerrit.ovirt.org/1866 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com
Ayal Baron has posted comments on this change.
Change subject: FIX spmStop security issue. ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1866 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: FIX spmStop security issue. ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/1866 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: fix spmStop failure ......................................................................
Patch Set 2: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1866 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix spmStop failure ......................................................................
fix spmStop failure
SPM_ID pool key is written after we are not SPM anymore. (By design.)
Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557 --- M vdsm/storage/sp.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1866 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
Haim Ateya has posted comments on this change.
Change subject: fix spmStop failure ......................................................................
Patch Set 2:
Fix.
-- To view, visit http://gerrit.ovirt.org/1866 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
vdsm-patches@lists.fedorahosted.org