3:24 a.m.
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/59865
to review the following change.
Change subject: storage: Remove unneeded multipath call
......................................................................
storage: Remove unneeded multipath call
As part of multipath rescan, we call iscsi and hba rescan.
These operations are sufficient to discover new devices and
detect changes in size.
Therefore, the multipath call is not needed and can be removed
improving the overall performance of GetDeviceList verb.
Detailed profiling :
time filename:lineno(function)
3.178 |hsm.py:1948(HSM._getDeviceList)
1.546 |--> sdc.py:80(StorageDomainCache.refreshStorage)
1.489 |--> multipath.py:65(rescan)
0.481 |--> iscsi.py:431(rescan) iscsi scan
0.076 |--> storage/hba.py:53(rescan) fc scan
0.912 |--> multipath.py:88(multipath) multipath
0.056 |--> multipath.py:92(resize_devices)
0.756 |--> lvm.py:843(getAllPVs)
0.756 |--> lvm.py:317(LVMCache._reloadpvs)
0.755 |--> lvm.py:290(LVMCache.cmd) pvs
0.871 |--> multipath.py:213(pathListIter)
0.029 |-->devicemapper.py:176(getPathsStatus) dmsetup status
Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Bug-Url: https://bugzilla.redhat.com/1303578
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M vdsm/storage/multipath.py
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/59865/1
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index 77c54a7..03fcb57 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -30,7 +30,6 @@
from collections import namedtuple
from vdsm import commands
-from vdsm import constants
from vdsm import supervdsm
from vdsm import udevadm
from vdsm import utils
@@ -73,9 +72,6 @@
# First rescan iSCSI and FCP connections
iscsi.rescan()
hba.rescan()
-
- # Now let multipath daemon pick up new devices
- misc.execCmd([constants.EXT_MULTIPATH], sudo=True)
# Scanning SCSI interconnects starts a storm of udev events. Wait until all
# events are processed, ensuring detection of new devices and creation or
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
3:24 a.m.
gerrit-hooks has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 1:
* #1303578::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1303578::OK, public bug
* Check Product::#1303578::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
5:21 a.m.
Freddy Rolland has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 1:
Verified with targetcli by adding a lun and increasing a lun.
Need to verify in FC
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
4:33 a.m.
Nir Soffer has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/59865/1//COMMIT_MSG
Commit Message:
Line 9: As part of multipath rescan, we call iscsi and hba rescan.
Line 10: These operations are sufficient to discover new devices and
Line 11: detect changes in size.
Line 12: Therefore, the multipath call is not needed and can be removed
Line 13: improving the overall performance of GetDeviceList verb.
Add note that this operation is risky and may get stuck.
Line 14:
Line 15: Detailed profiling :
Line 16: time filename:lineno(function)
Line 17: 3.178 |hsm.py:1948(HSM._getDeviceList)
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
5:19 a.m.
gerrit-hooks has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 2:
* #1303578::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1303578::OK, public bug
* Check Product::#1303578::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
5:20 a.m.
Freddy Rolland has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59865/1//COMMIT_MSG
Commit Message:
Line 9: As part of multipath rescan, we call iscsi and hba rescan.
Line 10: These operations are sufficient to discover new devices and
Line 11: detect changes in size.
Line 12: Therefore, the multipath call is not needed and can be removed
Line 13: improving the overall performance of GetDeviceList verb.
Add note that this operation is risky and may get stuck.
Done
Line 14:
Line 15: Detailed profiling :
Line 16: time filename:lineno(function)
Line 17: 3.178 |hsm.py:1948(HSM._getDeviceList)
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
10:04 a.m.
Nir Soffer has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
10:21 a.m.
Yaniv Kaul has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 2:
What causes a new device to be added to multipath though?
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
10:29 a.m.
Nir Soffer has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 2:
multipathd receive event from udev, there is no need to call multipath directly (based on
discussion with Ben Marzinsky, multipath developer).
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
3:50 a.m.
Freddy Rolland has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
8:45 a.m.
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Remove unneeded multipath call
......................................................................
storage: Remove unneeded multipath call
As part of multipath rescan, we call iscsi and hba rescan.
These operations are sufficient to discover new devices and
detect changes in size.
Therefore, the multipath call is not needed and can be removed
improving the overall performance of GetDeviceList verb.
Also, the multipath call is risky as it may get stuck.
Detailed profiling :
time filename:lineno(function)
3.178 |hsm.py:1948(HSM._getDeviceList)
1.546 |--> sdc.py:80(StorageDomainCache.refreshStorage)
1.489 |--> multipath.py:65(rescan)
0.481 |--> iscsi.py:431(rescan) iscsi scan
0.076 |--> storage/hba.py:53(rescan) fc scan
0.912 |--> multipath.py:88(multipath) multipath
0.056 |--> multipath.py:92(resize_devices)
0.756 |--> lvm.py:843(getAllPVs)
0.756 |--> lvm.py:317(LVMCache._reloadpvs)
0.755 |--> lvm.py:290(LVMCache.cmd) pvs
0.871 |--> multipath.py:213(pathListIter)
0.029 |-->devicemapper.py:176(getPathsStatus) dmsetup status
Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Bug-Url: https://bugzilla.redhat.com/1303578
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/59865
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/multipath.py
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8:45 a.m.
gerrit-hooks has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
......................................................................
Patch Set 3:
* #1303578::Update tracker: OK
* Set MODIFIED::bug 1303578::::#1303578::IGNORE, skipping for branch 'master'
--
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2803
days inactive
2873
days old
vdsm-patches@lists.fedorahosted.org
11 comments
4 participants
participants (4)
-
automation＠ovirt.org -
frolland＠redhat.com -
Nir Soffer -
ykaul＠redhat.com