7:11 a.m.
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: cleanup: reformat use of AC_ARG_ENABLE
......................................................................
build: cleanup: reformat use of AC_ARG_ENABLE
1. Use AS_HELP_STRING to format help.
2. Use autoconf variable for statement.
Change-Id: Iaf32239a946e299711a2f0de660f3ac8ec1fed59
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
1 file changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/18928/1
diff --git a/configure.ac b/configure.ac
index 4d8f4da..3c789b9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -44,15 +44,13 @@
AC_PROG_LN_S
AM_PATH_PYTHON([2.6])
-# Checking if hooks enables
-AC_ARG_ENABLE([hooks],
-[ --enable-hooks build hooks RPMs],
-[case "${enableval}" in
- yes) hooks=true ;;
- no) hooks=false ;;
- *) AC_MSG_ERROR([bad value ${enableval} for --enable-hooks]) ;;
-esac],[hooks=false])
-AM_CONDITIONAL([HOOKS], [test x$hooks = xtrue])
+AC_ARG_ENABLE(
+ [hooks],
+ [AS_HELP_STRING([--enable-hooks], [build hooks packages @<:@default=no@:>@])],
+ ,
+ [enable_hooks="no"]
+)
+AM_CONDITIONAL([HOOKS], [test "${enable_hooks}" = "yes"])
# Users and groups
AC_SUBST([VDSMUSER], [vdsm])
--
To view, visit http://gerrit.ovirt.org/18928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf32239a946e299711a2f0de660f3ac8ec1fed59
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
2:15 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: build: cleanup: reformat use of AC_ARG_ENABLE
......................................................................
Patch Set 1: Verified+1 Code-Review+1
Alon, how is this related to "the libvirt stuff"?
The patches seems all right by me.
--
To view, visit http://gerrit.ovirt.org/18928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf32239a946e299711a2f0de660f3ac8ec1fed59
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:12 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: build: cleanup: reformat use of AC_ARG_ENABLE
......................................................................
Patch Set 1:
Zhou can you please verify it with the libvirt stuff?
--
To view, visit http://gerrit.ovirt.org/18928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf32239a946e299711a2f0de660f3ac8ec1fed59
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-HasComments: No
7:18 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: build: cleanup: reformat use of AC_ARG_ENABLE
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4296/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3399/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4215/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/18928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf32239a946e299711a2f0de660f3ac8ec1fed59
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:07 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: cleanup: reformat use of AC_ARG_ENABLE
......................................................................
build: cleanup: reformat use of AC_ARG_ENABLE
1. Use AS_HELP_STRING to format help.
2. Use autoconf variable for statement.
Change-Id: Iaf32239a946e299711a2f0de660f3ac8ec1fed59
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/18928
Tested-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M configure.ac
1 file changed, 7 insertions(+), 9 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf32239a946e299711a2f0de660f3ac8ec1fed59
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:07 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: build: cleanup: reformat use of AC_ARG_ENABLE
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf32239a946e299711a2f0de660f3ac8ec1fed59
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3892
days inactive
3892
days old
vdsm-patches@lists.fedorahosted.org
5 comments
3 participants
participants (3)
-
Alon Bar-Lev -
Dan Kenigsberg -
Jenkins CI RO