Change in vdsm[master]: fixing pep8 issues in supervdsm

Yaniv Bronhaim has uploaded a new change for review.

Change subject: fixing pep8 issues in supervdsm
......................................................................

fixing pep8 issues in supervdsm

Change-Id: I7c4531269009e2607ce729270b0eb37428055f0b
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M vdsm/supervdsmServer.py
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/9672/1

diff --git a/vdsm/supervdsmServer.py b/vdsm/supervdsmServer.py
index 34fefdb..b533af4 100755
--- a/vdsm/supervdsmServer.py
+++ b/vdsm/supervdsmServer.py
@@ -47,7 +47,7 @@
 from storage.fileUtils import chown, resolveGid, resolveUid
 from storage.fileUtils import validateAccess as _validateAccess
 from vdsm.constants import METADATA_GROUP, EXT_UDEVADM, \
-        DISKIMAGE_USER, DISKIMAGE_GROUP, P_LIBVIRT_VMCHANNELS
+    DISKIMAGE_USER, DISKIMAGE_GROUP, P_LIBVIRT_VMCHANNELS
 from storage.devicemapper import _removeMapping, _getPathsStatus
 import storage.misc
 import configNetwork
@@ -61,7 +61,7 @@
 _UDEV_RULE_FILE_PREFIX = "99-vdsm-"
 _UDEV_RULE_FILE_EXT = ".rules"
 _UDEV_RULE_FILE_NAME = _UDEV_RULE_FILE_DIR + _UDEV_RULE_FILE_PREFIX + \
-        "%s-%s" + _UDEV_RULE_FILE_EXT
+    "%s-%s" + _UDEV_RULE_FILE_EXT
 
 RUN_AS_TIMEOUT = config.getint("irs", "process_pool_timeout")
 
@@ -207,7 +207,7 @@
     @logDecorator
     def validateAccess(self, user, groups, *args, **kwargs):
         return self._runAs(user, groups, _validateAccess, args=args,
-                kwargs=kwargs)
+                           kwargs=kwargs)
 
     @logDecorator
     def setSafeNetworkConfig(self):
@@ -216,7 +216,7 @@
     @logDecorator
     def udevTrigger(self, guid):
         cmd = [EXT_UDEVADM, 'trigger', '--verbose', '--action',
'change',
-                '--property-match=DM_NAME=%s' % guid]
+               '--property-match=DM_NAME=%s' % guid]
         rc, out, err = storage.misc.execCmd(cmd, sudo=False)
         if rc:
             raise OSError(errno.EINVAL, "Could not trigger change for device \
@@ -226,7 +226,7 @@
     def appropriateDevice(self, guid, thiefId):
         ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)
         rule = 'SYMLINK=="mapper/%s", OWNER="%s",
GROUP="%s"\n' % (guid,
-                DISKIMAGE_USER, DISKIMAGE_GROUP)
+               DISKIMAGE_USER, DISKIMAGE_GROUP)
         with open(ruleFile, "w") as rf:
             rf.write(rule)
 
@@ -322,7 +322,7 @@
         logging.config.fileConfig(LOG_CONF_PATH)
     except:
         logging.basicConfig(filename='/dev/stdout', filemode='w+',
-                level=logging.DEBUG)
+                            level=logging.DEBUG)
         log = logging.getLogger("SuperVdsm.Server")
         log.warn("Could not init proper logging", exc_info=True)
 
@@ -351,7 +351,7 @@
         log.debug("Setting up keep alive thread")
 
         monThread = threading.Thread(target=__pokeParent,
-                        args=[int(parentPid), address])
+                                     args=[int(parentPid), address])
         monThread.setDaemon(True)
         monThread.start()
 


--
To view, visit http://gerrit.ovirt.org/9672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c4531269009e2607ce729270b0eb37428055f0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: fixing pep8 issues in supervdsm
......................................................................


fixing pep8 issues in supervdsm

Change-Id: I7c4531269009e2607ce729270b0eb37428055f0b
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M vdsm/supervdsmServer.py
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Royce Lv: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c4531269009e2607ce729270b0eb37428055f0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fixing pep8 issues in supervdsm
......................................................................


Patch Set 1: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c4531269009e2607ce729270b0eb37428055f0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Royce Lv has posted comments on this change.

Change subject: fixing pep8 issues in supervdsm
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c4531269009e2607ce729270b0eb37428055f0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;