From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Introducing firewalld configurator
......................................................................
Patch Set 7: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/74883/7/automation/build-artifacts.packages....
File automation/build-artifacts.packages.fc24:
Line 14: python-coverage
Line 15: python2-decorator
Line 16: python-dateutil
Line 17: python-devel
Line 18: python-firewall
why bother with f24? we should kick it off master.
Line 19: python-nose
Line 20: python-inotify
Line 21: python-ioprocess
Line 22: python-mock
https://gerrit.ovirt.org/#/c/74883/7/automation/build-artifacts.packages....
File automation/build-artifacts.packages.fc25:
Line 15: python2-decorator
Line 16: python2-dateutil
Line 17: python3-dateutil
Line 18: python-devel
Line 19: python-firewall
I suspect you need python3-firewall to avoid CI-1
14:44:54 from firewall.client import FirewallClient
14:44:54 ImportError: No module named 'firewall'
Line 20: python-nose
Line 21: python-inotify
Line 22: python-ioprocess
Line 23: python-mock
https://gerrit.ovirt.org/#/c/74883/7/lib/vdsm/tool/configurators/firewall...
File lib/vdsm/tool/configurators/firewalld.py:
Line 31: 'ssh',
Line 32: # TODO: add remaining services
Line 33: )
Line 34:
Line 35: OPTIONAL_SERVICES = (
we don't have "optional services". We have two options: virt and gluster.
try:
import vdsm.gluster.api
except ImportError:
pass
else:
REQUIRED_SERVICE += (glusterfs, ...)
would be enough.
Line 36: 'glusterfs',
Line 37: # TODO: add remaining services
Line 38: )
Line 39:
PS7, Line 67: rpm
we should not bother about RPMs here; I'm still dreaming about Debian port.
--
To view, visit
https://gerrit.ovirt.org/74883
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b5f533de0b609c15a2482b2fba0ae713c3c33
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes