Change in vdsm[ovirt-3.3]: vm: Continue to sample after errors

[Nir Soffer]

Nir Soffer has uploaded a new change for review.

Change subject: vm: Continue to sample after errors
......................................................................

vm: Continue to sample after errors

When vm is running, we monitor disk usage, and if the disk becomes too
full, we extend the disk. This avoid pausing of the vm after io errors.
However, when sampling vm with multiple disks, an error when sampling
one disk exit the sampling function and skip the next disks, making this
machnisim useless.

This patch logs exceptions raised when sampling one disk and continue to
sample others.

This patch is for ovirt-3.3.1 only - master patch must be different
because of recent refactoring in this area.

Change-Id: I8dbe60a4d3b216a5cd998d163407c09b12f2f28c
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com&gt;
---
M vdsm/vm.py
1 file changed, 14 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/22575/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index 90ab5a7..2d0cece 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -506,20 +506,24 @@
             return
 
         for vmDrive in self._vm._devices[DISK_DEVICES]:
-            if not vmDrive.isExtendable():
-                continue
+            try:
+                if not vmDrive.isExtendable():
+                    continue
 
-            capacity, alloc, physical = \
-                self._vm._dom.blockInfo(vmDrive.path, 0)
+                capacity, alloc, physical = \
+                    self._vm._dom.blockInfo(vmDrive.path, 0)
 
-            if physical - alloc >= vmDrive.watermarkLimit:
-                continue
+                if physical - alloc >= vmDrive.watermarkLimit:
+                    continue
 
-            self._log.info('%s/%s apparent: %s capacity: %s, alloc: %s, '
-                           'phys: %s', vmDrive.domainID, vmDrive.volumeID,
-                           vmDrive.apparentsize, capacity, alloc, physical)
+                self._log.info('%s/%s apparent: %s capacity: %s, alloc: %s, '
+                               'phys: %s', vmDrive.domainID, vmDrive.volumeID,
+                               vmDrive.apparentsize, capacity, alloc, physical)
 
-            self._vm.extendDriveVolume(vmDrive)
+                self._vm.extendDriveVolume(vmDrive)
+            except Exception:
+                self._log.exception("%s/%s", vmDrive.domainID,
+                                    vmDrive.volumeID)
 
     def _updateVolumes(self):
         if not self._vm.isDisksStatsCollectionEnabled():


-- 
To view, visit http://gerrit.ovirt.org/22575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dbe60a4d3b216a5cd998d163407c09b12f2f28c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;

Itamar Heim has posted comments on this change.

Change subject: vm: Continue to sample after errors
......................................................................


Patch Set 1:

ping

-- 
To view, visit http://gerrit.ovirt.org/22575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbe60a4d3b216a5cd998d163407c09b12f2f28c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-HasComments: No

Itamar Heim has abandoned this change.

Change subject: vm: Continue to sample after errors
......................................................................


Abandoned

no activity. please restore if/when still relevant.

-- 
To view, visit http://gerrit.ovirt.org/22575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8dbe60a4d3b216a5cd998d163407c09b12f2f28c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;

[Nir Soffer]

Nir Soffer has restored this change.

Change subject: vm: Continue to sample after errors
......................................................................


Restored

Not solved yet

-- 
To view, visit http://gerrit.ovirt.org/22575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I8dbe60a4d3b216a5cd998d163407c09b12f2f28c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

[Nir Soffer]

Nir Soffer has abandoned this change.

Change subject: vm: Continue to sample after errors
......................................................................


Abandoned

Not needed now, this issue is fixed in master.

-- 
To view, visit https://gerrit.ovirt.org/22575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8dbe60a4d3b216a5cd998d163407c09b12f2f28c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: vm: Continue to sample after errors
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/22575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbe60a4d3b216a5cd998d163407c09b12f2f28c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No