Petr Horáček has posted comments on this change.
Change subject: net: early IP+link setup
......................................................................
Patch Set 20: Verified+1
(2 comments)
OVS networking was restored by vdsm-network-init.service
https://gerrit.ovirt.org/#/c/60371/19/lib/vdsm/network/netrestore.py
File lib/vdsm/network/netrestore.py:
Line 23: import os
Line 24:
Line 25: import six
Line 26:
Line 27: from vdsm.config import config
Needs to be done though 'compat'.
Done
Line 28: from vdsm.constants import P_VDSM_RUN
Line 29: from vdsm.utils import tobool
Line 30:
Line 31: from . import netswitch
Line 58:
Line 59: for net, attrs in six.iteritems(nets):
Line 60: try:
Line 61: netswitch.setup_ipv6autoconf({net: attrs})
Line 62: except Exception:
Why not just do it directly like this:
Done
Line 63: logging.exception('IPv6autoconf for {} failed.'.format(net))
Line 64:
Line 65: for net, attrs in six.iteritems(nets):
Line 66: try:
--
To view, visit
https://gerrit.ovirt.org/60371
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes