Change in vdsm[master]: lvm: Exclude faulty devices from lvm long filter

Sunday, 24 August 2014

Nir Soffer has uploaded a new change for review.

Change subject: lvm: Exclude faulty devices from lvm long filter
......................................................................

lvm: Exclude faulty devices from lvm long filter

lvm commands use filter to limit access to relevant devices. When the
filter includes a faulty device, lvm commands may block for several
minutes (stuck in D state). We have seen getDevicesList command stuck
for up to 10 minutes because of faulty devices in the long filter.

We used to build the filter from all multipath devices. Now we build the
filter only from devices which have at least one active paths.

    # multipath -ll
    360060160f4a0300038ed7058b5e9e311 dm-0 DGC     ,VRAID
    size=15G features='0' hwhandler='1 emc' wp=rw
    |-+- policy='service-time 0' prio=0 status=enabled
    | `- 4:0:3:0 sdd 8:48 failed faulty running
    `-+- policy='service-time 0' prio=0 status=enabled
      `- 4:0:2:0 sdb 8:16 failed faulty running
    360060160f4a030003268ab211002e411 dm-1 DGC     ,VRAID
    size=30G features='1 queue_if_no_path' hwhandler='1 emc' wp=rw
    |-+- policy='service-time 0' prio=4 status=active
    | `- 4:0:3:1 sde 8:64 active ready  running
    `-+- policy='service-time 0' prio=1 status=enabled
      `- 4:0:2:1 sdc 8:32 active ready  running

Previously, both devices were included in the filter, now only
360060160f4a030003268ab211002e411 will be included in lvm filter.

A faulty device which became active again will be included in lvm filter
after the next refresh (every 5 minutes), or after trying edit or create
a new storage domain.

lvm uses also short filter, including devices used by the certain vg or
lv. It is possible that we also have to exclude such devices from the
short filter. This will be handled later if needed.

Change-Id: I6d7a973bcefa95813fdc289847760c0955aca30c
Bug-Url: https://bugzilla.redhat.com/880738
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com&gt;
---
M vdsm/storage/lvm.py
M vdsm/storage/multipath.py
2 files changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/31875/1

diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 86edf55..9cfad01 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -244,7 +244,7 @@
             if not self._filterStale:
                 return self._extraCfg
 
-            self._extraCfg = _buildConfig(multipath.getMPDevNamesIter())
+            self._extraCfg = _buildConfig(multipath.getActiveMPDevNamesIter())
             _updateLvmConf(self._extraCfg)
             self._filterStale = False
 
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index ba98866..2b30995 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -382,6 +382,18 @@
         yield os.path.join(devicemapper.DMPATH_PREFIX, name)
 
 
+def getActiveMPDevNamesIter():
+    status = devicemapper.getPathsStatus()
+    for dmId, guid in getMPDevsIter():
+        active = [slave for slave in devicemapper.getSlaves(dmId)
+                  if status.get(slave) == "active"]
+        if not active:
+            log.warning("Skipping device %s - no active slave", guid)
+            continue
+        log.debug("Found device %s %s", guid, active)
+        yield os.path.join(devicemapper.DMPATH_PREFIX, guid)
+
+
 def getMPDevsIter():
     """
     Collect the list of all the multipath block devices.


-- 
To view, visit http://gerrit.ovirt.org/31875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d7a973bcefa95813fdc289847760c0955aca30c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;

    

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011