Mark Wu has uploaded a new change for review.
Change subject: Fix vm block stats lost after recovery ......................................................................
Fix vm block stats lost after recovery
We don't need call preparePaths() in the code path of vm recovery, because the 'path' has been prepared on vm creatation and saved in recovery file. But the flag _volumesPrepared still needs to be set to make the block stats can be collected.
Change-Id: I59a90cf909a07967f642d348e47b4928f7516c61 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/libvirtvm.py 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/6056/1 -- To view, visit http://gerrit.ovirt.org/6056 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I59a90cf909a07967f642d348e47b4928f7516c61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Fix vm block stats lost after recovery ......................................................................
Patch Set 1:
Actually, I am not sure the flag '_voulumesPrepared' is still necessary to protect the recovery process.
-- To view, visit http://gerrit.ovirt.org/6056 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I59a90cf909a07967f642d348e47b4928f7516c61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix vm block stats lost after recovery ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/102/ (1/2)
-- To view, visit http://gerrit.ovirt.org/6056 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I59a90cf909a07967f642d348e47b4928f7516c61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix vm block stats lost after recovery ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/136/ (2/2)
-- To view, visit http://gerrit.ovirt.org/6056 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I59a90cf909a07967f642d348e47b4928f7516c61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix vm block stats lost after recovery ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/102/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/136/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6056 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I59a90cf909a07967f642d348e47b4928f7516c61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itamar Heim has posted comments on this change.
Change subject: Fix vm block stats lost after recovery ......................................................................
Patch Set 2:
still relevant or should be abandoned?
Mark Wu has abandoned this change.
Change subject: Fix vm block stats lost after recovery ......................................................................
Abandoned
vdsm-patches@lists.fedorahosted.org