10:32 a.m.
Hello Nir Soffer, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32059
to review the following change.
Change subject: tool: Fix help message when is-configured fails
......................................................................
tool: Fix help message when is-configured fails
When is-configured fails for some modules, the help message suggested an
incorrect invocation:
vdsm-tool configure module-name
Instead of the correct:
vdsm-tool configure --module module-name
Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31783
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/32059/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 12cc0af..b799fde 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -111,7 +111,7 @@
One of the modules is not configured to work with VDSM.
To configure the module use the following:
-'vdsm-tool configure [module_name]'.
+'vdsm-tool configure [--module module-name]'.
If all modules are not configured try to use:
'vdsm-tool configure --force'
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
4:20 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails
......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/117/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:11 p.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
4:23 p.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails
......................................................................
Patch Set 4:
actually the bug url here is wrong. didn't catch it. please ignore, this just doc text
fix
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
4:22 p.m.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: tool: Fix help message when is-configured fails
......................................................................
tool: Fix help message when is-configured fails
When is-configured fails for some modules, the help message suggested an
incorrect invocation:
vdsm-tool configure module-name
Instead of the correct:
vdsm-tool configure --module module-name
Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127877
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31783
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32059
Tested-by: mooli tayer <mtayer(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
6:01 a.m.
mooli tayer has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
5:27 p.m.
Nir Soffer has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
10:33 a.m.
mooli tayer has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails
......................................................................
Patch Set 2:
Bug-url -> Bug-Url
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
3531
days inactive
3536
days old
vdsm-patches@lists.fedorahosted.org
7 comments
4 participants
participants (4)
-
Jenkins CI RO -
mtayer＠redhat.com -
Nir Soffer -
ybronhei＠redhat.com