Change in vdsm[master]: virt: stats: move the guest stats in a method

Francesco Romani has uploaded a new change for review.

Change subject: virt: stats: move the guest stats in a method
......................................................................

virt: stats: move the guest stats in a method

this patch moves the guest statistics gathering in
a separate method, with no functional changes.

Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 10 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/26554/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 922595e..894f717 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2414,15 +2414,9 @@
             self._addVmStatusStats(stats)
 
             try:
-                stats.update(self.guestAgent.getGuestInfo())
+                self._addGuestInfoStats(stats)
             except Exception:
                 return stats
-            memUsage = 0
-            realMemUsage = int(stats['memUsage'])
-            if realMemUsage != 0:
-                memUsage = (100 - float(realMemUsage) /
-                            int(self.conf['memSize']) * 100)
-            stats['memUsage'] = utils.convertToStr(int(memUsage))
 
             stats['balloonInfo'] = self._getBalloonInfo()
 
@@ -2518,6 +2512,15 @@
         if self.isMigrating():
             stats['migrationProgress'] =
self.migrateStatus()['progress']
 
+    def _addGuestInfoStats(self, stats):
+        stats.update(self.guestAgent.getGuestInfo())
+        memUsage = 0
+        realMemUsage = int(stats['memUsage'])
+        if realMemUsage != 0:
+            memUsage = (100 - float(realMemUsage) /
+                        int(self.conf['memSize']) * 100)
+        stats['memUsage'] = utils.convertToStr(int(memUsage))
+
     def isMigrating(self):
         return self._migrationSourceThread.isAlive()
 


-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 8:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9194/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9337/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8406/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 7: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 7:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9019/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9160/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8231/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 6:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8672/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7882/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8803/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8531/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7741/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8658/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8340/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7550/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8460/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8292/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7502/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8410/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8070/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8183/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7280/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7919/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7129/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/8031/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 10:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1400/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: stats: move the guest stats in a method
......................................................................


virt: stats: move the guest stats in a method

this patch moves the guest statistics gathering in
a separate method.

Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/26554
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 14 insertions(+), 11 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

Francesco Romani has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 8: Verified+1

Verified with 26550:
* checked the presence of the affected fields using vdsClient
* run patched VDSM with 3.5 engine without warnings

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 9: Verified+1

while waiting for 26142, tested by running a vm without the Guest Agent installed (without
any OS also) and checking using vdsClient all fields were present, and the method no blow
up.

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 9: Verified+1

Additional verification:
- installed and activated GA inside the guest, observed the expected fields in the
vdsClient output; indicators on engine updated accordingly
- restarted GA
- stopped GA, restarted VDSM, started GA again; stats output is enriched as soon as GA is
started; no errors in the logs.

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 9: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 9: -Verified

un-ticked verified until the very good points raised by Vinzenz are fulfilled.

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 9:

That means additionally of course. The easiest way to have this, is to install the guest
agent on the guest vm and you can start and stop it there. And rerun your tests by
restarting vdsm in the meantime (which would flush all data). If the guest agent service
is not running, after a restart of vdsm it's like it wouldn't be there.
When it is running it, obviously is.
But it's important to test both scenarios since this code has conditionals in it which
works with the data from the guest agent ;)

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 9:

To have the test reliable, you actually should test with the guest agent installed!

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 9:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9602/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8670/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9456/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26554/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2516:         stats.update(self._getVmStatus())
Line 2517: 
Line 2518:         try:
Line 2519:             stats.update(self._getGuestStats())
Line 2520:         except Exception:
I know this monstrosity exists in the orignal code, but perpetuating it is not nice. At
the least, check that self.guestAgent exists and log all other errors. If you would like
to explicitly ignore untrusted guest-generated values, please add a specific condition for
it.
Line 2521:             pass
Line 2522:         return stats
Line 2523: 
Line 2524:     def _getExitedVmStats(self):


-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Francesco Romani has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 8:

Verified with 26550:
- checked the presence of the affected fields using vdsClient
- run patched VDSM with 3.5 engine without warnings

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No