4 a.m.
Danny Rankevich has uploaded a new change for review.
Change subject: vdsm: error when creating a bond with more than one entwork attached
......................................................................
vdsm: error when creating a bond with more than one entwork attached
When creating a Bond with more than one network attached, the
code breaks since it is expecting a dictionary, but a list is used.
This fix creates the dictionary in the correct way.
Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
---
M vdsm/configNetwork.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/3010/1
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
2:49 a.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond with more than one network ...
Shahar Havivi has posted comments on this change.
Change subject: vdsm: error when creating a bond with more than one network attached
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
5:51 a.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond/nic with more than one netw...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: error when creating a bond/nic with more than one network attached
......................................................................
vdsm: error when creating a bond/nic with more than one network attached
When creating a Bond or Nic with more than one network attached, the
code breaks since it is expecting a dictionary, but a list is used.
This fix creates the dictionary in the correct way.
Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Signed-off-by: Danny Rankevich <danny.ran(a)redhat.com>
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com>
---
M vdsm/configNetwork.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Danny Rankevich: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
4:08 a.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond/nic with more than one netw...
Danny Rankevich has posted comments on this change.
Change subject: vdsm: error when creating a bond/nic with more than one network attached
......................................................................
Patch Set 4: Verified
Verified by QE
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
6:48 p.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond/nic with more than one netw...
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: error when creating a bond/nic with more than one network attached
......................................................................
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
5:06 a.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond with more than one network ...
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: error when creating a bond with more than one network attached
......................................................................
Patch Set 3:
Mark, could you suggest another patch on top of this one, fixing the nics issue?
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
4:08 a.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond with more than one network ...
Mark Wu has posted comments on this change.
Change subject: vdsm: error when creating a bond with more than one network attached
......................................................................
Patch Set 3:
Dan,
Please check the following code snippets
nics = defaultdict(lambda: {'networks':[], 'bonding':None})
'networks' is defined as a list
...
else:
assert 'nic' in networkAttrs
nics[networkAttrs['nic']]['networks'].append( network )
Append an item to the list.
...
for nic, nicAttrs in nics.iteritems():
networks = nicAttrs['networks']
if networks and nicAttrs['bonding']:
raise ConfigNetworkError(ne.ERR_USED_NIC, "Setup attached both network
and bonding to nic %s"%(nic))
if len(networks) > 1:
for network, networkAttrs in networks.iteritems():
^^^^ 'networks' is used as dictionary.
That's why I said it's the same problem existing for one nic attached to one more
networks.
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
3:36 a.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond with more than one network ...
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: error when creating a bond with more than one network attached
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
Mark, please explain the other issue. This patch is about a list being used as a
dictionary. Does it appear elsewhere?
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
3:33 a.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond with more than one network ...
Mark Wu has posted comments on this change.
Change subject: vdsm: error when creating a bond with more than one network attached
......................................................................
Patch Set 3:
In my understanding, the same problem exists in the case of one nic attached to one more
networks. Why do we not fix it together? If my understanding is wrong, please correct me.
Thanks.
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
5:04 a.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond with more than one network ...
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: error when creating a bond with more than one network attached
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
4:06 a.m.
New subject: Change in vdsm[master]: vdsm: error when creating a bond with more than one network ...
Shahar Havivi has posted comments on this change.
Change subject: vdsm: error when creating a bond with more than one network attached
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
Danny before pushing you need to run tests with pre-integration
--
To view, visit http://gerrit.ovirt.org/3010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
4430
days inactive
4437
days old
vdsm-patches@lists.fedorahosted.org
10 comments
4 participants
participants (4)
-
Dan Kenigsberg -
danny.ran＠redhat.com -
shavivi＠redhat.com -
wudxw＠linux.vnet.ibm.com