1:13 a.m.
Wenyi Gao has uploaded a new change for review.
Change subject: Fix usage message for vdsm-tool
......................................................................
Fix usage message for vdsm-tool
Fix usage message for vdsm-tool and pep8 problems
Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Signed-off-by: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
---
M Makefile.am
M vdsm-tool/__init__.py
M vdsm-tool/vdsm-tool
3 files changed, 17 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/4065/1
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
12:34 a.m.
ShaoHe Feng has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm-tool/vdsm-tool
Line 96: print "Usage: %s [options] <action> [arguments]\n" %
sys.argv[0]
sys.argv[0] is vdsm-tool.now vdsm-tool just support '-h' and '--help' two
options.
then the remaining argvs is the command, " <action> [module]".
action is the command name, the module seems not right.
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
7:51 p.m.
Wenyi Gao has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File Makefile.am
Line 51: vdsm/vdsm-tool
Here it should be "vdsm-tool" not "vdsm/vdsm-tool"
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
12:16 p.m.
ShaoHe Feng has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm-tool/vdsm-tool
Line 96: print "Usage: %s [options] <action> [arguments]\n" %
sys.argv[0]
Wenyi, sorry.
there is no example of module code in vdsm-tool/ path.
I just read vdsm-tool code, and find the dictionary tool_command collects all cmd with
"_vdsm_tool" attribute form all modules in vdsm-tool/ path
do know how to deal with the input command. so do not know the format of command usage.
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
9:40 a.m.
Mark Wu has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm-tool/vdsm-tool
Line 96: print "Usage: %s [options] <action> [arguments]\n" %
sys.argv[0]
Ryan,
I don't understand why you said we need specify both the command name and its module
name. From the code of vdsm-tool, it collects all exposed function by scanning all *.py
files in 'vdsm.tool' directory and puts into one dict: tool_command.
So, we needn't specify module name to invoke a command. If the same command name
appears in different module, it could cause conflict. In that case, specifying a module in
the command line of vdsm-tool could help. Is the "module" name is needed in
design but not implemented?
Thanks
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
9:24 a.m.
ShaoHe Feng has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
9:23 a.m.
ShaoHe Feng has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm-tool/vdsm-tool
Line 96: print "Usage: %s [options] <action> [arguments]\n" %
sys.argv[0]
sys.argv[0] is the module, and sys.argv[1:] are arguments.
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
7:56 p.m.
Wenyi Gao has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File Makefile.am
Line 51: vdsm/vdsm-tool
No, I mean the directory "vdsm/vdsm-tool" here.
....................................................
File vdsm-tool/vdsm-tool
Line 96: print "Usage: %s [options] <action> [arguments]\n" %
sys.argv[0]
It seems that we only need to specify the function name and needn't specify the
module. Actually, vdsm-tool will load up additional modules and put the exposed functions
in the modules into "tool_command{}". In the main() of the vdsm-tool, the
following code:
tool_command[cmd](*args[1:])
will pass the argument to the function and execute it.
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
2:18 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix usage message for vdsm-tool
......................................................................
Fix usage message for vdsm-tool
Fixed the following ussage message:
print "Usage: %s [options] <action> <module>\n" % sys.argv[0]
to:
print "Usage: %s [options] <action> [arguments]\n" % sys.argv[0]
Also fixed some pep8 problems
Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Signed-off-by: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
---
M Makefile.am
M vdsm-tool/__init__.py
M vdsm-tool/vdsm-tool
3 files changed, 17 insertions(+), 8 deletions(-)
Approvals:
Federico Simoncelli: Looks good to me, approved
Dan Kenigsberg: Verified
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
2:18 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 2: Verified
(1 inline comment)
....................................................
Commit Message
Line 10: print "Usage: %s [options] <action> <module>\n" %
sys.argv[0]
git-diff gives this information quite comfortably - no need to repeat it in commit
message.
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
10:05 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
7:18 a.m.
Ryan Harper has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
You should separate out your pep8 fixes from the code changes. This allows the
maintainers to cherry pick out just that change.
....................................................
File vdsm-tool/vdsm-tool
Line 96: print "Usage: %s [options] <action> [arguments]\n" %
sys.argv[0]
module is correct here. vdsm-tool will load up additional modules (.py files) and in each
of those modules, we can choose to expose certain functions. When you want to invoke one
of the exposed functions, you need to specify both the function name (this is the
<action>) and in which module this action occurs.
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
3:39 a.m.
Shu Ming has posted comments on this change.
Change subject: Fix usage message for vdsm-tool
......................................................................
Patch Set 1: Fails; I would prefer that you didn't submit this
(1 inline comment)
Please fix the comment below.
....................................................
File Makefile.am
Line 51: vdsm/vdsm-tool
Isn't vdsm/vdsm-tool/vdsm-tool here?
--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
4378
days inactive
4387
days old
vdsm-patches@lists.fedorahosted.org
12 comments
7 participants
participants (7)
-
Dan Kenigsberg -
Federico Simoncelli -
Ryan Harper -
shaohef＠linux.vnet.ibm.com -
shuming＠linux.vnet.ibm.com -
wenyi＠linux.vnet.ibm.com -
wudxw＠linux.vnet.ibm.com