Change in vdsm[master]: Revert "Fix getMasterDomain masterVersion handling"

Eduardo has uploaded a new change for review.

Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................

Revert "Fix getMasterDomain masterVersion handling"

This reverts commit ce280b09c776b33203847dc7e7ad77ee90a34bc0.

masterVersion is an exclusive property of RHEV-m.
There are no RHEV-M flows that not send the expected version.
All VDSM flows should have an expected version.
Towards a masterVersion (>0) meaning a master domain and
removing redundant metadata fields as isMaster, etc.

Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/955/1
--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo

Ayal Baron has posted comments on this change.

Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................

Patch Set 1:

Why was this introduced in the first place?

--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................

Patch Set 1: I would prefer that you didn't submit this

This breaks stuff. Fix the breakage or leave this in.

--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Saggi Mizrahi

Eduardo has posted comments on this change.

Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................

Patch Set 1:

The code was in this way before and tested.
What "stuff" is broken?

--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................

Patch Set 1:

Can't remember, and it works 90% of the time. I changed it back because I hit an error and remembered that originally I intended to have VDSM not test itself for the master version.

--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi

Ayal Baron has posted comments on this change.

Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................

Patch Set 2: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................

Revert "Fix getMasterDomain masterVersion handling"

This reverts commit ce280b09c776b33203847dc7e7ad77ee90a34bc0.

masterVersion is an exclusive property of RHEV-m.
There are no RHEV-M flows that not send the expected version.
All VDSM flows should have an expected version.
Towards a masterVersion (>0) meaning a master domain and
removing redundant metadata fields as isMaster, etc.

Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi