Federico Simoncelli has uploaded a new change for review.
Change subject: Don't rotate core dump logs on Fedora ......................................................................
Don't rotate core dump logs on Fedora
Core dumps are a system-level configuration and VDSM shouldn't try to override what the sysadmin decides.
Change-Id: I0a2e86614475fd13de3888b956b5512a24016281 --- M configure.ac M vdsm.spec.in M vdsm/Makefile.am A vdsm/cdumps-logrotate.conf A vdsm/vdsm-logrotate.conf D vdsm/vdsm-logrotate.conf.in 6 files changed, 27 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/991/1 -- To view, visit http://gerrit.ovirt.org/991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I0a2e86614475fd13de3888b956b5512a24016281 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Don't rotate core dump logs on Fedora ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... Commit Message Line 11: I'm not sure I agree with this statement. We configure the node for oVirt interoperability. This means overrding stuff on the system level (we want the cores to be log-collected, and not choke /root filesystem) These where reasonable requirement for downstream, and they still are for upstream.
If we somehow drop this feature/bug, we should stop playing with /proc/sys/kernel/core_pattern in vdsmd.init.
-- To view, visit http://gerrit.ovirt.org/991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0a2e86614475fd13de3888b956b5512a24016281 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Don't rotate core dump logs on Fedora ......................................................................
Patch Set 1: (1 inline comment)
.................................................... Commit Message Line 11: Choke /root with core dumps? That's quite a lot of segfaults. I agree (even if I feel you didn't propose) to stop playing with the core_pattern. Are you sure it's still working (through libvirt)? I can't see any qemu-kvm core file to get created:
# ps aux | grep qemu-kvm qemu 6255 /usr/libexec/qemu-kvm
# cat /proc/sys/kernel/core_pattern /var/log/core/core.%p.%t.dump
# kill -SIGSEGV 6255 # ls -l /var/log/core/ total 0
(If you kill SIGSEGV the vdsm process the core file is still created).
-- To view, visit http://gerrit.ovirt.org/991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0a2e86614475fd13de3888b956b5512a24016281 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Federico Simoncelli has abandoned this change.
Change subject: Don't rotate core dump logs on Fedora ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I0a2e86614475fd13de3888b956b5512a24016281 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org