[NEW PATCH] BZ#720919 spmprotect.sh: remove log noise (via gerrit-bot)

[Dan Kenigsberg]

New patch submitted by Dan Kenigsberg (danken(a)redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/696

commit cfcabd3b7bba2d6513b65216017828f326f2f660
Author: Dan Kenigsberg <danken(a)redhat.com&gt;
Date:   Wed Jul 13 14:23:45 2011 +0300

    BZ#720919 spmprotect.sh: remove log noise
    
    check_renew may have been called after fence or release have removed
    RENEWDIR. We should not print nonsense to the log in that case.
    
    Change-Id: I7ce575b863fcbdf6b0bf35747a23882a53ae1a39

diff --git a/vdsm/storage/protect/spmprotect.sh b/vdsm/storage/protect/spmprotect.sh
index 3548b17..f476446 100755
--- a/vdsm/storage/protect/spmprotect.sh
+++ b/vdsm/storage/protect/spmprotect.sh
@@ -135,7 +135,7 @@ function check_renew() {
             res=0
         fi
     fi
-    if pushd "$RENEWDIR" > /dev/null; then
+    if pushd "$RENEWDIR" > /dev/null 2>&1 ; then
         rm -f $list
         popd > /dev/null
     fi

Change in vdsm[master]: BZ#720919 spmprotect.sh: remove log noise

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#720919 spmprotect.sh: remove log noise
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.usersys.redhat.com/696
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ce575b863fcbdf6b0bf35747a23882a53ae1a39
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Change in vdsm[master]: BZ#720919 spmprotect.sh: remove log noise

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#720919 spmprotect.sh: remove log noise
......................................................................


BZ#720919 spmprotect.sh: remove log noise

check_renew may have been called after fence or release have removed
RENEWDIR. We should not print nonsense to the log in that case.

Change-Id: I7ce575b863fcbdf6b0bf35747a23882a53ae1a39
---
M vdsm/storage/protect/spmprotect.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.usersys.redhat.com/696
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ce575b863fcbdf6b0bf35747a23882a53ae1a39
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Change in vdsm[master]: BZ#720919 spmprotect.sh: remove log noise

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#720919 spmprotect.sh: remove log noise
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.usersys.redhat.com/696
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ce575b863fcbdf6b0bf35747a23882a53ae1a39
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Change in vdsm[master]: BZ#720919 spmprotect.sh: remove log noise

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#720919 spmprotect.sh: remove log noise
......................................................................


Patch Set 1: Verified

by Omri

--
To view, visit http://gerrit.usersys.redhat.com/696
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ce575b863fcbdf6b0bf35747a23882a53ae1a39
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;