Nir Soffer has uploaded a new change for review.
Change subject: sp: Sort dict literal by key ......................................................................
sp: Sort dict literal by key
With more then few items, it is easier to work with sorted items, and people are less likely to add duplicate keys at the end, as see in commit f9cf58b7bced.
Change-Id: I128ed804fcdbdf7b6b562f5cef662ae2ba2c9014 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm/storage/sp.py 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/65052/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index dbc89c9..8f98205 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1360,16 +1360,16 @@ self.masterDomain.sdUUID)
poolInfo = { - 'type': msdInfo['type'], - 'name': '', 'domains': '', + 'isoprefix': '', + 'lver': LVER_INVALID, 'master_uuid': self.masterDomain.sdUUID, 'master_ver': self._backend.getMasterVersion(), - 'lver': LVER_INVALID, - 'spm_id': SPM_ID_FREE, - 'version': str(msdInfo['version']), - 'isoprefix': '', + 'name': '', 'pool_status': 'connected', + 'spm_id': SPM_ID_FREE, + 'type': msdInfo['type'], + 'version': str(msdInfo['version']), }
poolInfo.update(self._backend.getInfo())
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 1: Verified+1
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Allon Mureinik has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
+1 on the code, minor corrections to the commit message
https://gerrit.ovirt.org/#/c/65052/5//COMMIT_MSG Commit Message:
PS5, Line 9: then s/then/tahn a/
PS5, Line 10: see s/see/seen/
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/65052/5//COMMIT_MSG Commit Message:
Line 5: CommitDate: 2016-10-04 00:17:28 +0300 Line 6: Line 7: sp: Sort dict literal by key Line 8: Line 9: With more then few items, it is easier to work with sorted items, and
s/then/tahn a/
Thanks, fixed in current version. Line 10: people are less likely to add duplicate keys at the end, as see in Line 11: commit f9cf58b7bced. Line 12: Line 13: Change-Id: I128ed804fcdbdf7b6b562f5cef662ae2ba2c9014
Line 6: Line 7: sp: Sort dict literal by key Line 8: Line 9: With more then few items, it is easier to work with sorted items, and Line 10: people are less likely to add duplicate keys at the end, as see in
s/see/seen/
Thanks, fixed in current version. Line 11: commit f9cf58b7bced. Line 12: Line 13: Change-Id: I128ed804fcdbdf7b6b562f5cef662ae2ba2c9014
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Freddy Rolland has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 9: Code-Review+1
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Adam Litke has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 10: Code-Review+2
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Sort dict literal by key ......................................................................
sp: Sort dict literal by key
With more than few items, it is easier to work with sorted items, and people are less likely to add duplicate keys at the end, as seen in commit f9cf58b7bced.
Change-Id: I128ed804fcdbdf7b6b562f5cef662ae2ba2c9014 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65052 Reviewed-by: Allon Mureinik amureini@redhat.com Reviewed-by: Freddy Rolland frolland@redhat.com Continuous-Integration: Jenkins CI Reviewed-by: Adam Litke alitke@redhat.com --- M vdsm/storage/sp.py 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key ......................................................................
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org