Change in vdsm[master]: when build vdsm, run_tests.sh runs two times it take a long ...

ShaoHe Feng has uploaded a new change for review.

Change subject: when build vdsm, run_tests.sh runs two times it take a long time, remove
the "make check" in vdsm.spec.in
......................................................................

when build vdsm, run_tests.sh runs two times
it take a long time, remove the "make check" in vdsm.spec.in

Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/3907/1
--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: add NOSE_EXCLUDE to avoid running the test twice

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: add NOSE_EXCLUDE to avoid running the test twice
......................................................................


add NOSE_EXCLUDE to avoid running the test twice

when build vdsm by autobuild.sh, it runs the test twice for the same build.
It takes a long time, add NOSE_EXCLUDE to avoid this.
To skip test step, you can run "NOSE_EXCLUDE=.* ./autobuild.sh".

Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
---
M autobuild.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Hui Kai Ran: Looks good to me, but someone else must approve
  Zhou Zheng Sheng: Verified


--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Hui Kai Ran <huikai.ran(a)gmail.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: add NOSE_EXCLUDE to avoid running the test twice

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: add NOSE_EXCLUDE to avoid running the test twice
......................................................................


Patch Set 4: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Hui Kai Ran <huikai.ran(a)gmail.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: add NOSE_EXCLUDE to avoid running the test twice

Hui Kai Ran has posted comments on this change.

Change subject: add NOSE_EXCLUDE to avoid running the test twice
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

Since we are going to add more test cases, it really save much time.

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Hui Kai Ran <huikai.ran(a)gmail.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: add NOSE_EXCLUDE to avoid running the test twice

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: add NOSE_EXCLUDE to avoid running the test twice
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: add NOSE_EXCLUDE to avoid running the test twice

Zhou Zheng Sheng has posted comments on this change.

Change subject: add NOSE_EXCLUDE to avoid running the test twice
......................................................................


Patch Set 4: Verified

I tested 'autobuild.sh', it just run check once and save time. I also tested
'make rpm', it still checked and ran 'make check'.

I think this is good. Because there is no need for 'autobuild.sh' test twice in
one build, and if we 'make rpm' alone it must be test. The modification keep this
logic right.

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: when build vdsm buy autobuild.sh, "make check" runs two time...

ShaoHe Feng has posted comments on this change.

Change subject: when build vdsm buy autobuild.sh, "make check" runs two times.
It take a long time, add NOSE_EXCLUDE to avoid this. you can run "NOSE_EXCLUDE=.*
./autobuild.sh" to avoid all "make check"
......................................................................


Patch Set 3:

There's an error in the commit message of patch Set 2.
Modify and re-push.

this patch can "make check" just one times, when you use
"./autobuild.sh", 

But if you are short in time and do not care about code quality, avoid "make
check" step, you can run " NOSE_EXCLUDE=.* ./autobuild.sh"

more about NOSE_EXCLUDE, look this http://www.ovirt.org/wiki/Features/Nose_tests

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: when build vdsm buy autobuild.sh, "make check" runs two time...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: when build vdsm buy autobuild.sh, "make check" runs two times.
It take a long time, add NOSE_EXCLUDE to avoid this. you can run "NOSE_EXCLUDE=.*
./autobuild.sh" to avoid all "make check"
......................................................................


Patch Set 3: I would prefer that you didn't submit this

Ok, it makes some sense not to run the test twice for the same build.

But, please fix your commit message (one short line, empty line, long description), and
fix the regexp in build.sh (no slash should be there, I believe).

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;

ShaoHe Feng has posted comments on this change.

Change subject: when build vdsm, run_tests.sh runs two times it take a long time, remove
the "make check" in vdsm.spec.in
......................................................................


Patch Set 1:

another question, if the LANG is not English, such as Chinese, we will build like this
"LANG=C ./autobuild.sh".
so can LANG be setted in autobuild.sh?

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;

ShaoHe Feng has posted comments on this change.

Change subject: when build vdsm, run_tests.sh runs two times it take a long time, remove
the "make check" in vdsm.spec.in
......................................................................


Patch Set 1:

in autobuild.sh line 34, it run "make check" once. This "make check"
generate an log. In My opinion, wan can cancel his make check.

and then in line 50,  rpmbuild will run "make check" again, for the "make
check" in vdsm.spec.in.
but how to store the "make check" log this time?

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: when build vdsm, run_tests.sh runs two times it take a long time, remove
the "make check" in vdsm.spec.in
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I think that the %check section is educationally important - that's how rpms should be
made.

Where is the second place `make check` is called? I see it only there when I `make rpm`.

Note again that you can skip nose tests altogether with NOSE_EXCLUDE.

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;

ShaoHe Feng has posted comments on this change.

Change subject: when build vdsm, run_tests.sh runs two times it take a long time, remove
the "make check" in vdsm.spec.in
......................................................................


Patch Set 1:

should I remove the "make check" from autobuild.sh instead of vdsm.spec.in ?

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;