Change in vdsm[master]: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6

Peter V. Saveliev has uploaded a new change for review.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6

lvs in this version has two more attrs

Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
---
M vdsm/storage/lvm.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/2785/1
--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev

Peter V. Saveliev has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Peter V. Saveliev

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 1: I would prefer that you didn't submit this

this would explode when run on older versions of lvm, that has only 6 attrs.

you should either require the newer lvm2 version (and make vdsm fail to install on Fedora 16), or make Vdsm run with both versions of lvm.

(brute force fix is to chop sAttr according to len(attrMask) in lvm._attr2NamedTuple.

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Ayal Baron has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Argh.  I didn't consider the F16 issue  when I asked Edu to simply support the new format (mea culpa, sorry).

Supporting both would require vdsm to check what LVM version is used and parse accordingly (if later on LVM remove 2 fields it should not be treated as the current set of 6 automatically).

Truncating would be based on the assumption that LVM preserved the first 6, is there any guarantee for that from LVM? I don't particularly like assumptions...

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Eduardo has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 1:

"brute force fix is to chop sAttr according to len(attrMask) in lvm._attr2NamedTuple" (D. K.)

No brute force fixes please.

We need to define if two lvm versions should be supported simultaneously.
If the answer is affirmative, we can define the  mask constant at installation.
If not the patch is OK, adding the lvm version requirement on the VDSM package.

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 1:

I am not happy with checking lvm versions. Verifying that lvm does not do silly things as dropping old attributes or changing their order is good enough for me.

But if everyone is against chopping at 6 chars, we can push this patch with "Requires lvm2 >" - we should only ask the lvm guys to build that version for Fedora 16 Testing.

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Eduardo has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 1:

For sure we will not check lvm versions in vdsm.
Only the minimal lvm version requisite should be changed in the .spec.
We want the code to be "fragile" if the lvm output changes and   we should not try to parse partially unknown outputs.
This is the main reason for reject parsing outputs or errors.
Choping the output is not sufficient.

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 2:

OK, let's push it with lvm version restriction for RHEL.

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Eduardo has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 3: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 4: I would prefer that you didn't submit this

Please make it so it's backward compatible, meaning that it works with both new and old version of lvm

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm.spec.in
Line 41: Requires: lvm2 >= 2.02.95-2
Hi Peet,

As we talked today over irc, looks like the correct reference here is *95-1*
Thanks !

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Peter V. Saveliev has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 5: Verified

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 6: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Ayal Baron has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 6: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 6: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

Patch Set 6:

ok, ok. no more Fedora 16 for you. Use rawhide for Vdsm.

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................

fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6

lvs in this version has two more attrs

Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
---
M vdsm.spec.in
M vdsm/storage/lvm.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Saggi Mizrahi: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg:

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi