Igor Lvovsky has uploaded a new change for review.
Change subject: Add general Device class ......................................................................
Add general Device class
Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2 --- M vdsm/libvirtvm.py M vdsm/vm.py 2 files changed, 23 insertions(+), 40 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/792/1 -- To view, visit http://gerrit.ovirt.org/792 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Add general Device class ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/792 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add general Device class ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/libvirtvm.py Line 803: class LibvirtNetwork(vm.Device): NetInterface is more exact
.................................................... File vdsm/vm.py Line 61: class Drive(Device): I agree that maintaining this class here is not fruitful; you can do just like with LibvitVm.Network
-- To view, visit http://gerrit.ovirt.org/792 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has abandoned this change.
Change subject: Add general Device class ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/792 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org