Saggi Mizrahi has uploaded a new change for review.
Change subject: Persist active storage provider connections ......................................................................
Persist active storage provider connections
In order for VDSM to gracefully handle restarts it should make sure all connections it was asked to manage before the crash are continued to be managed when it goes up.
Note that there is no reconnection logic yet.
Change-Id: I91f29671e87e76765bc86907fb2d03318861d045 --- M vdsm/storage/hsm.py M vdsm/storage/storageProviderConnectionMonitor.py 2 files changed, 59 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/1116/1 -- To view, visit http://gerrit.ovirt.org/1116 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I91f29671e87e76765bc86907fb2d03318861d045 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Persist active storage provider connections ......................................................................
Patch Set 8: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/storage/hsm.py Line 1861: ac = self._connectionMonitor.manage(uri, uri.replace("/", "_")) As I mentioned in http://gerrit.ovirt.org/#change,1038,patchset=10 it's look like wrong function parameters
Line 1918: ac = self._connectionMonitor.unmanage(uri.replace("/", "_")) as above
-- To view, visit http://gerrit.ovirt.org/1116 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I91f29671e87e76765bc86907fb2d03318861d045 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Persist active storage provider connections ......................................................................
Patch Set 8: (1 inline comment)
.................................................... File vdsm/storage/hsm.py Line 1861: ac = self._connectionMonitor.manage(uri, uri.replace("/", "_")) It isn't
-- To view, visit http://gerrit.ovirt.org/1116 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I91f29671e87e76765bc86907fb2d03318861d045 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has abandoned this change.
Change subject: Persist active storage provider connections ......................................................................
Patch Set 8: Abandoned
Took a different direction
-- To view, visit http://gerrit.ovirt.org/1116 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I91f29671e87e76765bc86907fb2d03318861d045 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org