Martin Polednik has uploaded a new change for review.
Change subject: osinfo: memoize runtime_kernel_flags ......................................................................
osinfo: memoize runtime_kernel_flags
Unless magic is involved, we don't expect the underlying kernel to change. Memoize to save uname calls.
Change-Id: I9c015f0086ca66231f9f4dbe0c1f16d3fd197f31 Signed-off-by: Martin Polednik mpolednik@redhat.com --- M lib/vdsm/osinfo.py 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/65716/1
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py index f5342a4..bf2cd5f 100644 --- a/lib/vdsm/osinfo.py +++ b/lib/vdsm/osinfo.py @@ -248,6 +248,7 @@ return pkgs
+@utils.memoized def runtime_kernel_flags(): ret = os.uname() try:
gerrit-hooks has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags ......................................................................
Patch Set 1:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Francesco Romani has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags ......................................................................
Patch Set 1: Code-Review+2
gerrit-hooks has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags ......................................................................
Patch Set 2:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, no bug url/s found * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags ......................................................................
Patch Set 3:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, no bug url/s found * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Martin Polednik has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags ......................................................................
Patch Set 3: Verified+1
Francesco Romani has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags ......................................................................
Patch Set 3: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: osinfo: memoize runtime_kernel_flags ......................................................................
osinfo: memoize runtime_kernel_flags
Unless magic is involved, we don't expect the underlying kernel to change. Memoize to save uname calls.
Change-Id: I9c015f0086ca66231f9f4dbe0c1f16d3fd197f31 Signed-off-by: Martin Polednik mpolednik@redhat.com Reviewed-on: https://gerrit.ovirt.org/65716 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani fromani@redhat.com --- M lib/api/vdsm-api.yml M lib/vdsm/osinfo.py M vdsm/caps.py M vdsm_hooks/nestedvt/before_vm_start.py 4 files changed, 34 insertions(+), 12 deletions(-)
Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified
gerrit-hooks has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags ......................................................................
Patch Set 4:
* update_tracker: OK * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org