Nir Soffer has posted comments on this change.
Change subject: Add hawkular reporter to reports
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/58660/6/lib/vdsm/reports/hawkular.py
File lib/vdsm/reports/hawkular.py:
Line 76: items = _queue.pop()
Line 77: if items is _STOP:
Line 78: break
Line 79: client.put(items)
Line 80: _running = False
I don't agree, as only after we pop the _STOP we actually stopped
running.
Ok, modifying _running here has an advantage, although we don't care
about it.
However logging when a thread start and stop is very important. Without it, how can you
know that the thread started are existed?
--
To view, visit
https://gerrit.ovirt.org/58660
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71f538184855f7c58bba66acd7b6dea3a53db71b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes