Michal Skrivanek has posted comments on this change.
Change subject: snapshot: Add VM.freeze() and VM.thaw() apis. ......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43058/4/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 2872: conf.update(driveParams) Line 2873: self.saveState() Line 2874: Line 2875: def freeze(self): Line 2876: guest = snapshot.GuestAgent(self._dom, self.log) as noted in the other patch - you can easily do it right here (we don't really need yet another wrapper just to pass arguments further. We already have API.py)
or delegate to the current guest agent class (which is a different agent, but it does handle connection/socket to qemu-ga, so why not...)
Or alternatively implement that functionality in "our" guest agent which would delegate to qemu-ga internally. Advantage is that unlike libvirt we are a bit better in handling non responding cases Line 2877: return guest.freeze_filesystems() Line 2878: Line 2879: def thaw(self): Line 2880: guest = snapshot.GuestAgent(self._dom, self.log)
vdsm-patches@lists.fedorahosted.org