Change in vdsm[master]: NetReload: netmodels for addNetwork

Giuseppe Vallarelli has posted comments on this change.

Change subject: NetReload: netmodels for addNetwork
......................................................................

Patch Set 4: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 76:                          bootproto=bootproto)
Line 77:     return topObj
Line 78: 
Line 79: 
Line 80: def objectivizeBond(bonding, bondingOptions, nics, mtu, _netinfo,
I feel that this logic should belong to the Bond class, the same applies for objectivizeNic and respective Nic class. What do you think?
Line 81:                     configurator):
Line 82:     if bonding and nics:
Line 83:         slaves = []
Line 84:         bondMtu = netinfo.getMaxMtu(nics, mtu)

--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Giuseppe Vallarelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server