2:47 a.m.
New patch submitted by Saggi Mizrahi (smizrahi(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/749
commit 654681f63df38137cadf09d08182b2cbfa45f883
Author: Saggi Mizrahi <smizrahi(a)redhat.com>
Date: Wed Jul 27 10:43:30 2011 +0300
BZ#725963 - Fix error handling in isBlockDevice()
Change-Id: I9f519354e7fec56a85ef908765d33e7b92ad82bb
diff --git a/vdsm/storage/devicemapper.py b/vdsm/storage/devicemapper.py
index 8873fbd..76d31a3 100644
--- a/vdsm/storage/devicemapper.py
+++ b/vdsm/storage/devicemapper.py
@@ -70,15 +70,18 @@ def resolveDevName(devName):
try:
return getDmId(devName)
except Exception:
- raise OSError(errno.ENOENT, "No such multipath device `%s`" % devName)
+ raise OSError(errno.ENOENT, "No such block device `%s`" % devName)
def isVirtualDevice(devName):
devName = resolveDevName(devName)
return os.path.exists(os.path.join("/sys/devices/virtual/block/",
devName))
def isBlockDevice(devName):
- devName = resolveDevName(devName)
- return os.path.exists(os.path.join("/sys/block/", devName))
+ try:
+ devName = resolveDevName(devName)
+ return os.path.exists(os.path.join("/sys/block/", devName))
+ except OSError:
+ return False
def getAllSlaves():
8:24 a.m.
New subject: Change in vdsm[master]: BZ#725963 - Fix error handling in isBlockDevice()
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#725963 - Fix error handling in isBlockDevice()
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/devicemapper.py
Line 83: except OSError:
No need to log, you don't log whenever os.path.exists returns False do you
--
To view, visit http://gerrit.usersys.redhat.com/749
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f519354e7fec56a85ef908765d33e7b92ad82bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
8:24 a.m.
New subject: Change in vdsm[master]: BZ#725963 - Fix error handling in isBlockDevice()
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#725963 - Fix error handling in isBlockDevice()
......................................................................
BZ#725963 - Fix error handling in isBlockDevice()
Change-Id: I9f519354e7fec56a85ef908765d33e7b92ad82bb
---
M vdsm/storage/devicemapper.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Yotam Oron: Looks good to me, but someone else must approve
Haim Ateya: Verified
--
To view, visit http://gerrit.usersys.redhat.com/749
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f519354e7fec56a85ef908765d33e7b92ad82bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
8:24 a.m.
New subject: Change in vdsm[master]: BZ#725963 - Fix error handling in isBlockDevice()
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#725963 - Fix error handling in isBlockDevice()
......................................................................
Patch Set 1: Looks good to me, approved
I'd prefer an additional log, but no time to argue right now.
--
To view, visit http://gerrit.usersys.redhat.com/749
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f519354e7fec56a85ef908765d33e7b92ad82bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
3:19 a.m.
New subject: Change in vdsm[master]: BZ#725963 - Fix error handling in isBlockDevice()
Haim Ateya has posted comments on this change.
Change subject: BZ#725963 - Fix error handling in isBlockDevice()
......................................................................
Patch Set 1: Verified
verified, patch fix the problem.
--
To view, visit http://gerrit.usersys.redhat.com/749
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f519354e7fec56a85ef908765d33e7b92ad82bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
2:59 a.m.
New subject: Change in vdsm[master]: BZ#725963 - Fix error handling in isBlockDevice()
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#725963 - Fix error handling in isBlockDevice()
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/devicemapper.py
Line 83: except OSError:
this is not going to happen very often. why not log it?
--
To view, visit http://gerrit.usersys.redhat.com/749
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f519354e7fec56a85ef908765d33e7b92ad82bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
2:55 a.m.
New subject: Change in vdsm[master]: BZ#725963 - Fix error handling in isBlockDevice()
Yotam Oron has posted comments on this change.
Change subject: BZ#725963 - Fix error handling in isBlockDevice()
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/749
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f519354e7fec56a85ef908765d33e7b92ad82bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
4678
days inactive
4678
days old
vdsm-patches@lists.fedorahosted.org
6 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Haim Ateya -
smizrahi＠redhat.com -
Yotam Oron