Eli Qiao has uploaded a new change for review.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Modify vdsm/netinfo.py for PEP8 compliance
Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Signed-off-by: Eli Qiao qiaoliyong@gmail.com --- M vdsm/netinfo.py 1 file changed, 62 insertions(+), 28 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/4334/1 -- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/85/
-- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/85/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Patch Set 1: Fails; I would prefer that you didn't submit this
Hello Eli,
Can you please rebase your patch?
Thanks Douglas
-- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/383/
-- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/383/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/389/
-- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/389/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Tal Nisan has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Patch Set 1:
Hi Eli, Is the patch still relevant?
-- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Tal Nisan tnisan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Patch Set 1:
Hi Tal. I think this patch is outdated. There is a similar patch (commit ID 6822c4b) merged.
-- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliyong@gmail.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Tal Nisan tnisan@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has abandoned this change.
Change subject: Modify vdsm/netinfo.py for PEP8 compliance ......................................................................
Abandoned
Zhou Zheng Sheng Mar 15, 2013
Patch Set 1:
Hi Tal. I think this patch is outdated. There is a similar patch (commit ID 6822c4b) merged.
vdsm-patches@lists.fedorahosted.org