Change in vdsm[master]: Removed useless docs from lvm.py. man pages exist for a reas...

Saggi Mizrahi has uploaded a new change for review.

Change subject: Removed useless docs from lvm.py. man pages exist for a reason
......................................................................

Removed useless docs from lvm.py. man pages exist for a reason

Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
---
M vdsm/storage/lvm.py
1 file changed, 0 insertions(+), 99 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/680/1
--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: Removed useless docs from lvm.py. man pages exist for a reason
......................................................................

Patch Set 1: I would prefer that you didn't submit this

As I am working through the vdsm API I am finding the need to document the dictionary structures for parameters and return values.  I think we should at least have a formalized API with argument validation and documentation before we submit patches like this that destroy documentation.

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke

Eduardo has posted comments on this change.

Change subject: Removed useless docs from lvm.py. man pages exist for a reason
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Not related.

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Eduardo

Saggi Mizrahi has posted comments on this change.

Change subject: Removed useless docs from lvm.py. man pages exist for a reason
......................................................................

Patch Set 1:

eduardo, this is why it's on a patch of it's own.

aglitke, the docs I am deleting are just the pasted output of `lvm lvs -o help`. I don't see why we need to keep a copy of it when it's easily accessible and updated in lvm. To me it just looks like pasting the output of `pydoc os` at the beginning of the file.

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Removed useless docs from lvm.py

Ayal Baron has posted comments on this change.

Change subject: Removed useless docs from lvm.py
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Removed useless docs from lvm.py

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Removed useless docs from lvm.py
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Removed useless docs from lvm.py

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Removed useless docs from lvm.py
......................................................................

Patch Set 2: Verified; Looks good to me, approved

A lot of Vdsm documentation is missing, but this lvm documentation is not a true replacement.

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Removed useless docs from lvm.py

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Removed useless docs from lvm.py
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Removed useless docs from lvm.py

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Removed useless docs from lvm.py
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Removed useless docs from lvm.py

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Removed useless docs from lvm.py
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Removed useless docs from lvm.py

Ayal Baron has posted comments on this change.

Change subject: Removed useless docs from lvm.py
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Removed useless docs from lvm.py

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Removed useless docs from lvm.py
......................................................................

Patch Set 6: Verified; Looks good to me, approved

Sorry, I've had enough of this patch. Rebasing, acking, submitting.

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Removed useless docs from lvm.py

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Removed useless docs from lvm.py
......................................................................

Removed useless docs from lvm.py

Man pages exist for a reason.

Keeping copies of documentation in the code is necessary cry and will only
grow stale in time.

To see the list of fields run:
$ lvm lvs -o help

Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
---
M vdsm/storage/lvm.py
1 file changed, 0 insertions(+), 99 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi